The concatjson from manidlou

concatjson's People

Contributors

Stargazers

Watchers

concatjson's Issues

concantjson explodes with strings including a {

concantjson "explodes" i.e. generates an uncaught parser error, when trying to parse {}{"foo":"{"}. Somehow concantjson doesn't handle curly brackets right. And yes, they don't need to be escaped according to RFC 7159, and the subjson {"foo":"{"} is parsed without problems by JSON.parse()

support concatenated JSON delimited with whitespace

Currently, concatenated JSON delimited with whitespace doesn't parse. Here's a diff (apologies if a pull request is preferred) that has a test for this and a proposed fix:

diff --git a/concatjson.js b/concatjson.js
index 2b4755b..30248cc 100644
--- a/concatjson.js
+++ b/concatjson.js
@@ -3,7 +3,7 @@ const thru = require('through2')
 const split = require('split2')
 
 function parse () {
-  return split('}{', parseStream)
+  return split(/}\s*{/, parseStream)
 
   function parseStream (dat) {
     if (!dat) return null
diff --git a/test/test.js b/test/test.js
index d4b88b9..8fb9b7f 100644
--- a/test/test.js
+++ b/test/test.js
@@ -233,3 +233,34 @@ test('+ parse() > more curly brackets in object contents', t => {
     })
   })
 })
+
+test('+ parse() > test whitespace allowed between concatenated objects', t => {
+  const Readable = require('stream').Readable;
+  const out = new Readable;
+  out._read = function noop() {};
+
+  const parser = cj.parse();
+  out.pipe(parser);
+
+  /*
+   * This is the (second) example from the "Concatenated JSON" section from
+   * the Wikipedia article on "JSON Streaming."
+   */
+  out.push('{"some":"thing\\n"}\n');
+  out.push('{"may": {\n');
+  out.push('  "include":"nested",\n');
+  out.push(' "objects":[\n');
+  out.push('      "and","arrays"\n');
+  out.push(' ]\n');
+  out.push('}}\n');
+  out.push(null);
+
+  parser.once('data', dat => {
+    t.equal(dat.some, 'thing\n')
+    parser.once('data', dat => {
+      t.deepEqual(dat.may,
+        { include: 'nested', objects: [ 'and', 'arrays' ] });
+      t.end()
+    })
+  })
+})

Recommend Projects