Dark mode about mailgo

[manzinello]

Hi, I'm already working on this (https://mailgo.dev/docs/dark-mode), but if you want to help / give some suggestion it would be awesome!

[manzinello]

No problem and thank you again for your suggestions!

Here 2 screens of the new (colorful) dark mode.

Maybe I will close this issue, but if you want to give other suggestions they will be appreciated, thank you!

[Kvanrooyen]

If no one is working on this, I would like to make a start on this.

[Kvanrooyen]

Is there anything that you need help with in particular? If not I think I will start by testing what you have and seeing if I can help out that way

[manzinello]

Well a test of dark mode would be very useful! I've implemented it but not tested very well, thank you.
About the dark mode there is something that is not convincing me: the installation if mailgo is not imported in bundle but for example using a <script>. I want to give the possibility to use the dark mode also importing /dist/mailgo.min.js and so I create with webpack a /dist/mailgo.dark.min.js, I don't think it's a good idea. Maybe a config (attached to window?) is a better idea, I don't know...

[Kvanrooyen]

I've had a chance now to test a little, during this time I have noticed a few things.

1. When using dark mode, the application names are all the same colour (see screenshot for reference) whereas in the default mode, they are coloured.
   
   
2. For me the default text colour on the dark theme is a little dark and can be difficult to read for some people

I want to give the possibility to use the dark mode also importing /dist/mailgo.min.js and so I create with webpack a /dist/mailgo.dark.min.js, I don't think it's a good idea.

I agree with this, I was thinking maybe you could use a class in the HTML. Something like this:

<!-- Default -->
<a href="mailto:[email protected],[email protected]?cc=ciao">[email protected]</a>
<!-- Dark -->
<a href="mailto:[email protected],[email protected]?cc=ciao" class="dark">[email protected]</a>

What do you think?

[manzinello]

Thank you so much Keagan! All your suggestions/impressions are really appreciated, in particular:

1. you have right, it could be a good idea to add a colour for the dark mode actions (very light maybe), the colour now appears only on hover;
2. thank you so much, I can work on this.

About the dark mode setting I will think about it... Maybe a developer/user want to apply the dark mode to all the mailto links, if we use the class all the mailto have to be changed... I really don't know which is the best way to proceed here, maybe a combination of the solutions: if mailto.dark.min.js is imported all the mailgo are in dark mode, but with mailgo.min.js you can also specify a single (or more) dark mode mailgo? I don't know, what do you think about?

[Kvanrooyen]

I agree with you, I think a combination of the two would work best

[manzinello]

I've worked on the mixed solution (mailgo.dark.min.js or class="dark"), you can see the updated documentation here https://mailgo.dev/docs/installation#dark-mode and here also come examples https://mailgo.dev/docs/dark-mode.

I am also working on your suggestion about the colors also in dark mode!

[manzinello]

Relased mailgo 0.9.10 with a colorful dark mode and the new dark class. Thank you again!

[Kvanrooyen]

I haven't had the chance to look into it yet - been incredibly busy at work lately. I should get some free time this weekend, and will give it look through. Glad I could be of some help!

[Kvanrooyen]

Looks good. I think you can close this issue, if I need to I can always open it again

[manzinello]

Thank you!