maoiscat / mpv-osc-framework Goto Github PK

I have just tested this. I'm not well-versed in LUA, but when I first tried to launch mpv with the demo osc per the instructions, I received these errors:

$ mpv test-file.mp4 

[expansion] 
[expansion] stack traceback:
[expansion] 	/home/me/.config/mpv/scripts/expansion.lua:6: in main chunk
[expansion] 	[C]: at 0x56299274b590
[expansion] 	[C]: at 0x56299274ba50
[expansion] Lua error: /home/me/.config/mpv/scripts/expansion.lua:6: module 'oscf' not found:
[expansion] 	no field package.preload['oscf']
[expansion] 	no file '/usr/share/luajit-2.1.0-beta3/oscf.lua'
[expansion] 	no file '/usr/local/share/lua/5.1/oscf.lua'
[expansion] 	no file '/usr/local/share/lua/5.1/oscf/init.lua'
[expansion] 	no file '/usr/share/lua/5.1/oscf.lua'
[expansion] 	no file '/usr/share/lua/5.1/oscf/init.lua'
[expansion] 	no file '/usr/local/lib/lua/5.1/oscf.so'
[expansion] 	no file '/usr/lib/lua/5.1/oscf.so'
[expansion] 	no file '/usr/local/lib/lua/5.1/loadall.so'
[main] 
[main] stack traceback:
[main] 	/home/me/.config/mpv/scripts/main.lua:4: in main chunk
[main] 	[C]: at 0x56299274b590
[main] 	[C]: at 0x56299274ba50
[main] Lua error: /home/me/.config/mpv/scripts/main.lua:4: module 'expansion' not found:
[main] 	no field package.preload['expansion']
[main] 	no file '/usr/share/luajit-2.1.0-beta3/expansion.lua'
[main] 	no file '/usr/local/share/lua/5.1/expansion.lua'
[main] 	no file '/usr/local/share/lua/5.1/expansion/init.lua'
[main] 	no file '/usr/share/lua/5.1/expansion.lua'
[main] 	no file '/usr/share/lua/5.1/expansion/init.lua'
[main] 	no file '/usr/local/lib/lua/5.1/expansion.so'
[main] 	no file '/usr/lib/lua/5.1/expansion.so'
[main] 	no file '/usr/local/lib/lua/5.1/loadall.so'

To fix the problem, I have replaced (in expansion.lua) require 'oscf' with dofile'oscf.lua', and replaced (in main.lua) require 'expansion' with dofile'expansion.lua'.

I believe this most likely has to do with LUA path configurations on the user's system, so I don't think your demo instructions on the README will work for all users.

I don't know what the correct solution is, I am only alerting you to the issue. It may just require an additional note on the README about module paths.

Thank you for your work

Can playback brightness be added to the osc in any way? I have trawled around wwwwwww but it seems that it is not a very (or at all) requested feature or it is not possible and everyone (except me) knows that. I am using MPV on a linux tablet without a keyboard only controlling mpv with the osc and a mouse so keyboard shortcuts is not really what i am looking for.

why isn't there a video track switch in the oscf? and show cache in the scale

Hello, I noticed that oscf and other osc made with the framework don't include a bar for the loaded buffer or cache when streaming a video, and I myself have 0 clue about LUA and modifying the files. I tried but I managed nothing. If possible, how could I add it back?

(I think your OSC scripts are really good and I've been using dark-box for a while but I wanted to try the other scripts.)

Hello,

The UI is disappearing when I drag subtitles over the "mpv-osc-modern" main.lua.

How can I fix it ? Is it a problem related to the config or something ?

I wanted to add some background colors to OSD so that the texts are easier to see under white/light videos. mpv does have a setting --osd-back-color to do so. However, since your expansion.lua draws the mpv logo using OSD too (3 circles + 1 triangle), there then will be 3+1=4 overlapping OSD background boxes. Is there a way to fix it, for example, by ignoring --osd-back-color when you draw the logo?

Note: I discovered this issue in mpv-osc-modern but figured I should probably report it here, hoping you may be more active here.

Steps to reproduce:

1. Apply expansion.lua, main.lua, oscf.lua in this repo;
2. Set a random color for OSD background, for example: mpv --osd-back-color=1/0/0/0.5
3. You should be able to see the following: