marcelowa / promise-all-properties Goto Github PK

hello, thanks for creating a library! i've just needed an Promise.all for object. that is, i think it'd be useful to also have a named export, since it makes importing name consistent across files.

import promiseAllProperties from "promise-all-properties"
import { promiseAllProperties } from "promise-all-properties"

Hi! Would support for Promise.allSettled() be an acceptable increase in scope for this package? It is a useful alternative to Promise.all when you want to work with all rejected promises, and not just the first one.

I'm considering implementing this myself and contributing it as a pull request, but I don't want to go ahead before knowing if this is okay. Implementation-wise there won't be much of a difference between wrapping Promise.allSettled() and Promise.all(), since they both take an iterable of promises or values and return an array with the results in the same order, though the types would need to be different.

Promise.all(), like everything else promise-related, doesn't care if you don't give it a promise, it'll just pass it through. This lib should mirror that property.

Promise.all([ 1, 2, 3 ]).then(console.log) // => [1, 2, 3]

Some cosmetic issue with NPM and Markdown:

https://www.npmjs.com/package/promise-all-properties

Checkboxes at the end of the document are not rendered - maybe NPM thinks they are links