marcosero / msmapclustering Goto Github PK

Currently, MSMapClustering has addMSAnnotation and addMSAnnotations to force the annotations added to "((MSMapClusteringDelegate *)self.delegate)._allAnnotationsMapView". This is good.

But we don't have good "remove annotation(s)" methods to handle this quickly.

Currently, what I do is writing 2 lines in my main view controller:
(Note: this example is doing "removing all annotations on the map)

[_mapView removeAnnotations:[_mapView annotations]];
[((MSMapClusteringDelegate *)_mapView.delegate)._allAnnotationsMapView removeAnnotations:[((MSMapClusteringDelegate *)_mapView.delegate)._allAnnotationsMapView annotations]];

It is better if we could have 2 methods
removeMSAnnotation
removeMSAnnotations

Thanks for the great class.

Suggestion in MSMapClusteringDelegate.m

We need this to balance the "addObserver call. Otherwise, the app would crash when the map view is unloaded.

• (void)dealloc
  {
  [[NSNotificationCenter defaultCenter] removeObserver:self name:@"AnnotationsAdded" object:nil];
  }

MSAnnotation has a strong reference to its clusterAnnotation which creates a retain cycle (since clusterAnnotation in turn has a strong reference back to its contained annotations). To break this, I declared clusterAnnotation as weak, and now, MSAnnotations are getting released properly.