marcpage / financial_game Goto Github PK

Currently the database is hardcoded to an sqlite3 db in the objects directory. This should be configured and not hardcoded.

See financial_game/__main__.py

Pipe the output of pylint through sed and prefix warning lines with "##[warning]"

pr_build.py works fine on Linux and macOS but not so well on Windows.

You can see this if you run:

python3 tests/test_email.py

Review simple CSS at: https://github.com/dbohdan/classless-css

Tests need to be added for account and account_statement

We should set the following cookie attributes:

• Secure (may need to be only if server is in deployed mode)
• HttpOnly
• SameSite
• Expire
• Max-Age

From: https://blog.jscrambler.com/best-practices-for-secure-session-management-in-node
Cookies can be secured using the following attributes:

1. The Secure attribute instructs the browser to set cookies over HTTPS only. This attribute prevents MITM attacks since the transfer is over TLS.
2. The HttpOnly attribute blocks the ability to use the document.cookie object. This prevents XSS attacks from stealing the session identifier.
3. The SameSite attribute blocks the ability to send a cookie in a cross-origin request. This provides limited protection against CSRF attacks.
4. Setting Domain & Path attributes can limit the exposure of a cookie. By default, Domain should not be set and Path should be restricted.
5. Expire & Max-Age allow us to set the persistence of a cookie.

Pipe the output of black through sed and prefix warning lines with "##[warning]"

Have the percentage set at the top of pr_build.sh

parse the output of code coverage and detect values lower than the minimum and fail build

The warning is:

financial_game/model.py:14: MovedIn20Warning: The ``declarative_base()`` function is now available as sqlalchemy.orm.declarative_base(). (deprecated since: 1.4) (Background on SQLAlchemy 2.0 at: https://sqlalche.me/e/b8d9)

Alchemy_Base = sqlalchemy.ext.declarative.declarative_base()

The code should be updated so this is not shown

Pipe the output of flake8 through sed and prefix warning lines with "##[warning]"

See https://flask.palletsprojects.com/en/2.2.x/tutorial/deploy/