mariadb-corporation / dev-example-todo Goto Github PK

bug in example:

                updateTaskStatus(conn, atoi(argv[2]), argv[3]);

passes a char* as a bool. as a result the task is always set to completed = true.

more correct would be

      updateTaskStatus(conn, atoi(argv[2]), atoi(argv[3])); 

i don't know why that the following error happened

i do link code with dll and lib which download on official link and install it with msi

for os version reasion?

pls help me!!

node_modules are not ignored in the repo

Hey, I have an error but I don't understand where it comes from yet I use the example.

https://github.com/mariadb-corporation/dev-example-todo/blob/master/api/nodejs/basic/server.js#L9

Cors package is missing from dependencies https://github.com/mariadb-corporation/dev-example-todo/blob/master/api/nodejs/basic/package.json

if you run the example app code with address sanatizer it shows that it leaks memory.

==451983==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 256 byte(s) in 1 object(s) allocated from:
    #0 0x7fdb7d4f8f27 in operator new(unsigned long) ../../../../src/libsanitizer/asan/asan_new_delete.cpp:99
    #1 0x7fdb7d3bbdd0 in sql::mariadb::SelectResultSet::create(sql::mariadb::Results*, sql::mariadb::Protocol*, sql::mariadb::capi::st_mysql*, bool) /home/buildbot/src/src/SelectResultSet.cpp:79

The issue is the result sets, eg this:

        sql::ResultSet *res = stmnt->executeQuery("select * from tasks");

needs to be wrapped in a unique_ptr to ensure it gets cleaned up at end of scope:

    std::unique_ptr<sql::ResultSet> res(stmnt->executeQuery("select * from tasks"));

This applies to every result_set in the example app. ie every time stmnt->execute*() is called