mariusbancila / moneycpp

A C++ library for handling monetary values

Hi there 👋

My name is Marius Băncilă. I'm a developer, architect, author, speaker passionate about programming, mainly working with C++ and C# and related technologies. I'm a Microsoft MVP for developer technologies.

👨‍💻 What I do is:

• ✍️ blog at https://mariusbancila.ro
• 📚 write books
• 🧰 contribute to open-source projects
• 📢 speak at local conferences
• 🌐 contribute to developer communities (StackOverflow, CodeProject, etc.)

📚 My books:

• Template Metaprogramming with C++ (ISBN 9781803243450)
• Modern C++ Programming Cookbook, 3rd Edition (ISBN 9781835080542)
• Modern C++ Programming Cookbook, 2nd Edition (ISBN 9781800208988)
• Modern C++ Programming Cookbook (ISBN 9781786465184)
• The Modern C++ Challenge (ISBN 9781788993869)
• Learn C# Programming (ISBN 9781789805864)

💬 How to reach me:

moneycpp's Issues

Add complete set of arithmetic operations

It would be good to be able to use money objects arithmetically unimpeded using math libraries such as xtensor or DataFrame. To provide a concrete example of something that's not currently supported, would be finding the standard deviation of a timeseries of money objects:

std::vector<money> population {{5.0, currency::USD}, {10.0, currency::USD}, {30.0, currency::USD}};
money std_dev = sqrt((1/population.size()) * sum(pow(population - mean(population)), 2.0));

The element of this calculation not currently supported is the pow operation. This can't be easily computed using addition (though it can), but providing the multiplication overload for two money types would drastically improve the ease of a calculation such as this:

template <typename TValue1>
inline auto operator*(money<TValue1> const & lhs, money<TValue1> const & rhs)

Understandably only the TValue2 overload has been implemented for this, as the result of money * money doesn't necessarily make a lot of sense - the result isn't necessarily a sensible value that represents money. However, these kinds of operations are essential in performing any kind of data analysis.

Additional overloads that would be useful:

• operator*(TValue2, money) - so that the float doesn't have to be the second argument - i.e. moneyVal * 2.0 and 2.0 * moneyVal are both valid statements
• operator/(money, money)
• operator/(TValue2, money)
• operator%(money, money)
• operator%(TValue2, money)
• operator+=(TValue2)
• operator+=(money)
• operator-=(TValue2)
• operator-=(money)
• operator*=(TValue2)
• operator*=(money)
• operator\=(TValue2)
• operator\=(money)
• operator<<(stream, money) - It would be good to be able to convert money objects to strings for debugging/output

It may also be necessary to implement proxy functions for some of the std math functions: std::pow, std::sqrt, std::sin, etc.

One complication to consider here is that I think it's probably prudent to ensure that these operations are all homogeneous. You could have heterogeneous calculations in which you do conversions between currencies on the fly, but especially for the operations in which a new money object is generated, there would be ambiguity around which currency the result should be denominated in. The calculation is exactly the same, the result is exactly the same, so it actually doesn't matter which currency is assigned to the object, but for the sake of consistency and type safety I think that it would be prudent to throw an error if the currencies of the money objects in a multiplication or a division are not the same. I can see that you've done this for the equality operator so it seems that this perspective is consistent with yours.

idea: expand to allow for std::decimal

gcc's libstdc++ includes std::decimal64, a compact 64-bit, exact decimal representation for money values.

It would be nice if moneycpp were expanded to allow for std::decimal32, std::decimal64, and std::decimal128 as the representational type.

References:
specifications
code

Make find_country_currency in country_currency.h inline

I think you forgot to make find_country_currency inline.

If not inline, since this is a header-only library, you would get multiple definitions of find_country_currency during linking if the file is included in multiple compilation unit (cpp files). #pragma once won't help in this case.