markathomas / serverpush Goto Github PK

The request object accessed in the inner class access of ServerPushApplicationServlet returns null for the context path when accessed in separate Thread.

Hi,
I know you are not activly working on ServerPush anymore. However it works best for us out of all push plugins.
One issue when we close the Application to have the user relogin. While the browser reloads, the comet call runs on server 500 and display the ugly red box.
The reason for that is that the pushing/broadcasting code has troubles with that.
I propose this as safeguard code:

public void broadcastForApplication(Application application, String json) {
    if (application == null || !application.isRunning()) return;
    final String sessionID = ((WebApplicationContext)application.getContext()).getHttpSession().getId();
    final Broadcaster bc = this.getBroadcaster(sessionID);
    if (bc != null)
        bc.broadcast(json);
}

In our case the app is already stopped and getContext would return null