Duration: 0? about scroll-js

[markcellus]

why not just change the Element.scrollTop property or use Element.scrollIntoView?

FWIW, the original goal of this package was to fill gaps in the spec in regards to scrolling elements--not necessarily to provide functionality that is already supported.

FYI, depending on the browsers you need to support, a lot of what this package does (i.e. scroll(), scrollTo()), are already natively supported by evergreen browsers. Animations are a part of that spec also.

[markcellus]

After reviewing code though, it wouldn't hurt to implement a fix for this situation. Specifying a 0 duration should work. I'll submit a fix in a bit for it.

[thejamespower]

We were using this library as a cross-browser solution, as we prefer to abstract non-standard (Internet Explorer) code out so it doesn't 'clutter' our code. We are using this library for across several UI components and it's all working well for us, was just a little stumped as to why zero duration didn't work. Thanks for the fix though.

[markcellus]

Got ya, almost done with the fix. will open a pr and up the patch version once done. 👍

[markcellus]

Hey @thejamespower opened a PR with the fix tests to ensure this is not actually a bug: #17

[markcellus]

Hey @thejamespower to clarify, there is really no fix for this because I tested passing duration:0 and it actually works. Not sure why it's not working for you. Do you mind pasting an example of your use case?

[markcellus]

going to close this since I could not reproduce. if you're still having problems, feel free to comment in this thread.

[thejamespower]

Thanks @mkay581, I'll investigate further our end.