GithubHelp home page GithubHelp logo

Massive NPM package about scroll-js HOT 3 CLOSED

markcellus avatar markcellus commented on June 14, 2024
Massive NPM package

from scroll-js.

Comments (3)

markcellus avatar markcellus commented on June 14, 2024

Just to clarify, this package only has only four dependencies at the time of this writing. These dependencies are necessary to allow the use of ES6 syntax and features while also being backwards compatible (mainly for IE browsers) when building this package manually.

Note that when using the npm package, it is assuming that you are building your own dist file. And even though other nested deps are installed, they are not shipped with your production code, so it shouldn't make a difference of how many packages get installed.

If you are only interested in the smallest JS file possible without having to install npm deps, I suggest you download the dist files directly (as indicated in the Installation instructions on the README).

I am closing this as this is not an issue. However, please feel free to still comment here and I will make time to address any further concerns.

from scroll-js.

dominikfiala avatar dominikfiala commented on June 14, 2024

Thanks for your reply! It seems that we differ in NPM philosophy.
I never considered to build dist files of third party packages in Node ecosystem. I always thought that building third-party packages is meant only for development of the package. And I thought that thats the reason for devDependencies.

from scroll-js.

markcellus avatar markcellus commented on June 14, 2024

@dominikfiala I understand your concerns. The reason the package was built this way was to give developers a way to use their own build processes to ensure the final output file would be as small as possible. However, for the reasons you've stated and out of convenience, I do think it is best at this point to point the npm package at the dist file and remove the unnecessary dependencies to customize the build.

I have done this and added it to version 1.8 (latest version) of this package. Thanks for your contribution.

from scroll-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.