GithubHelp home page GithubHelp logo

android-sdk's People

Contributors

bsadiwala avatar everlyd avatar glo40610 avatar kodeshpa avatar marketoreleng avatar mbijapur avatar pandemanish avatar skharemarketo avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Forkers

everlyd pandemanish rajeshkp mahtorohit johnpaulcm

android-sdk's Issues

The app still receive notification when the function uninitializeMarketoPush is called

Hello everyone,
I'm using Marketo SDK to push notifications for my React Native project. I have an issue when the user logout, uninitializeMarketoPush of SDK is called, and I saw logs from Makero SDK: 'Unregistered device from FCM'. But when I push a notification from Marketo admin
, the app still receives a notification.
You can see my screenshot below.

OS: Android
Version: 11

Screenshot 2023-10-24 at 15 46 06 Screenshot 2023-10-24 at 15 46 55

Support Firebase Cloud Messaging

Google has replaced GCM with FCM (Firebase Cloud Messaging). This library should add support for FCM or add a variant that does.

ANR caused by Marketo SDK 0.8.0

I'm using the latest Marketo SDK 0.8.0 and I'm getting reports of ANRs in production. Please investigate and fix as soon as you can. Please and thank you!

Stacktrace:

ANR: Application did not respond for at least 5000 ms
        at com.marketo.Marketo.b(SourceFile:20822)
        at com.marketo.Marketo$a.onActivityStopped(SourceFile:947)
        at android.app.Application.dispatchActivityStopped(Application.java:282)
        at android.app.Activity.onStop(Activity.java:1984)
        at androidx.fragment.app.FragmentActivity.onStop(FragmentActivity.java:541)
        at androidx.appcompat.app.AppCompatActivity.onStop(AppCompatActivity.java:185)

Threads:

SourceFile:20822com.marketo.Marketo.b	
SourceFile:947com.marketo.Marketo$a.onActivityStopped	
Application.java:282android.app.Application.dispatchActivityStopped	
Activity.java:1984android.app.Activity.onStop	
FragmentActivity.java:541androidx.fragment.app.FragmentActivity.onStop	
AppCompatActivity.java:185androidx.appcompat.app.AppCompatActivity.onStop	
Base.java:95com.mobilemarket.app.Base.onStop	
MyActivity.kt:214com.mobilemarket.onboarding.MyActivity.onStop	
Instrumentation.java:1432android.app.Instrumentation.callActivityOnStop	
Activity.java:7653android.app.Activity.performStop	
ActivityThread.java:4372android.app.ActivityThread.callActivityOnStop	
ActivityThread.java:4350android.app.ActivityThread.performStopActivityInner	
ActivityThread.java:4425android.app.ActivityThread.handleStopActivity	
TransactionExecutor.java:192android.app.servertransaction.TransactionExecutor.performLifecycleSequence	
TransactionExecutor.java:165android.app.servertransaction.TransactionExecutor.cycleToPath	
TransactionExecutor.java:142android.app.servertransaction.TransactionExecutor.executeLifecycleState	
TransactionExecutor.java:70android.app.servertransaction.TransactionExecutor.execute	
ActivityThread.java:1947android.app.ActivityThread$H.handleMessage	
Handler.java:106android.os.Handler.dispatchMessage	
Looper.java:214android.os.Looper.loop	
ActivityThread.java:7032android.app.ActivityThread.main	
Method.java:-2java.lang.reflect.Method.invoke	
RuntimeInit.java:494com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run	
ZygoteInit.java:965com.android.internal.os.ZygoteInit.main

Proguard issue

Hi, I'm using proguard with Marketo version 0.7.7 and after adding this library to my project I can't make a build 'cause I have some troubles with proguard. I've added these lines to rules:
-dontwarn com.marketo.*
-dontnote com.marketo.*
-keep class com.marketo.**{ *; }

But it's not enough as I see. Also, I don't know what is an error here and how fix it, could you review it?
The first one is output without Marketo. The second one - when marketo is in the project.

  1. https://prnt.sc/li86ix
  2. http://prntscr.com/li886h

Crashing App after receiving push on Android 8.0

Here is the stack trace:

Fatal Exception: java.lang.RuntimeException: Unable to start receiver com.marketo.MarketoBroadcastReceiver: java.lang.IllegalStateException: Not allowed to start service Intent { act=com.google.android.c2dm.intent.RECEIVE flg=0x1000010 pkg=com.fivestars.mma cmp=com.fivestars.mma/com.marketo.MarketoIntentService (has extras) }: app is in background uid UidRecord{c72cc0e u0a179 RCVR idle change:idle|uncached procs:1 seq(0,0,0)}
       at android.app.ActivityThread.handleReceiver(ActivityThread.java:3194)
       at android.app.ActivityThread.-wrap17(Unknown Source)
       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1672)
       at android.os.Handler.dispatchMessage(Handler.java:106)
       at android.os.Looper.loop(Looper.java:164)
       at android.app.ActivityThread.main(ActivityThread.java:6494)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)
Caused by java.lang.IllegalStateException: Not allowed to start service Intent { act=com.google.android.c2dm.intent.RECEIVE flg=0x1000010 pkg=com.fivestars.mma cmp=com.fivestars.mma/com.marketo.MarketoIntentService (has extras) }: app is in background uid UidRecord{c72cc0e u0a179 RCVR idle change:idle|uncached procs:1 seq(0,0,0)}
       at android.app.ContextImpl.startServiceCommon(ContextImpl.java:1521)
       at android.app.ContextImpl.startService(ContextImpl.java:1477)
       at android.content.ContextWrapper.startService(ContextWrapper.java:650)
       at android.content.ContextWrapper.startService(ContextWrapper.java:650)
       at marketo.push.MktoWakefulBroadcastReceiver.a(SourceFile:86)
       at com.marketo.MarketoBroadcastReceiver.onReceive(SourceFile:42)
       at android.app.ActivityThread.handleReceiver(ActivityThread.java:3187)
       at android.app.ActivityThread.-wrap17(Unknown Source)
       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1672)
       at android.os.Handler.dispatchMessage(Handler.java:106)
       at android.os.Looper.loop(Looper.java:164)
       at android.app.ActivityThread.main(ActivityThread.java:6494)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)

Fix might me moving from IntentService to JobIntentService.

Use ActivityLifecycleCallbacks instead of imposing onStart/onStop ceremony on all Activities

It doesn't seem that there is any real need to impose the requirement that all consumers of this SDK perform the following ceremony on every Activity in their Application:

  1. Configure activities. Add Marketo.onStart, Marketo.onStop in all or in base activity as shown below.

This burden can removed from SDK consumers if the Marketo SDK uses Application.ActivityLifecycleCallbacks to do whatever work is necessary in onStart and onStop.

Marketo android SDK Failed to init

Hi all, first time connecting to android Marketo 0.8.6

I am getting an IOException, 'failed to initialize MarketoSDK 0.8.6 IOException'

Munchkin ID: 824-XEX-790.

I have read on iOS Side that initialization fails because the Marketo subscription is not set up correctly?

Thank you

Do not track user's location with LocationManager

The LOCATION is classified as a dangerous permission group by Android and therefore requires a permission prompt for targetSdkVersion 23 and higher. Regardless, collecting information about the user's location is a highly offensive practice for applications that do not incorporate location into their functionality. There is no need for Marketo to attempt to collect location information by default.

Add Marketo SDK to JCenter and/or MavenCentral

Downloading and adding an AAR to the project works fine. However it would be much more convenient and quick to get set up if it was added to JCenter and/or MavenCentral so that we could just add one line to a Gradle build file to add the Marketo library.

Could we please have builds deployed to JCenter and/or MavenCentral?

SDK is incompatible with Android SDK 23

I have added the Marketo android SDK to our app. When minifying the app through ProGuard, I notice that the app is now failing to build as it using a deprecated android method:

Warning:marketo.push.a: can't find referenced method 'void setLatestEventInfo(android.content.Context,java.lang.CharSequence,java.lang.CharSequence,android.app.PendingIntent)' in library class android.app.Notification

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.