GithubHelp home page GithubHelp logo

ios-sdk's People

Contributors

caffeineflo avatar everlyd avatar kodeshpa avatar mahtorohit avatar mbijapur avatar pandemanish avatar skharemarketo avatar zubhium avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

ios-sdk's Issues

Allow MarketoLead() to set MarketoID or PersonID

Hi,

Currently we are able to associate a lead using email as follows:

let profile = MarketoLead()
profile?.setEmail(user.email)
Marketo.sharedInstance()?.associateLead(profile)
But this would create a NEW PERSON activity for this user.

Are we able to add an option for us to set the Person ID so we don't misleadingly send this NEW PERSON activity type?

For example:
let profile = MarketoLead()
profile?.setProfileId(user.id)
Marketo.sharedInstance()?.associateLead(profile)

associateLead doesn't fix this problem due to different PERSON IDs even they have the same emails, and some of our actions are based on NEW PERSON activity type.

Regards,
Kai

[iOS Privacy Manifest] ITMS-91055: Invalid API reason declaration

Hi team,

the app I'm working on currently uses the latest version 0.8.5 which was specifically released to address Apple's upcoming changes regarding privacy manifest.
Kudos for addressing such requirement early in advance.

Nevertheless, I got this warning upon uploading a new build to App Store:

ITMS-91055: Invalid API reason declaration - The PrivacyInfo.xcprivacy for the “Frameworks/MarketoFramework.framework/MarketoFramework” file contains “C617.1” as the value for a NSPrivacyAccessedAPITypeReasons key instead of a valid reason code for using an API in the NSPrivacyAccessedAPICategoryUserDefaults category. While no action is required at this time, starting May 1, 2024, when you upload a new app or app update, values for NSPrivacyAccessedAPITypeReasons keys in your app’s privacy manifest must be valid reason codes for the corresponding API category. For more details about this policy, including a list of required reason APIs and approved reasons for usage, visit: https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api.

Considering the message above and looking at the manifest changes on version 0.8.5, one of two things seems to have happened:

  • the value "C617.1" was placed under the string NSPrivacyAccessedAPICategoryUserDefaults while it should have been placed under the string NSPrivacyAccessedAPICategoryFileTimestamp , instead;
  • besides "CA92.1", the other intended value to place under NSPrivacyAccessedAPICategoryUserDefaults was not "C617.1" but another one.

Could you please confirm and address this issue in a timely manner? (i.e. prior to the May 1, 2024 deadline)
Thank you

Cannot initialise SDK when turn on in-app message

We implement SDK and test Push notification successfully.
However, we face with crashing after turn on In-app message program on Admin site. The crashing occur right at initial code
let sharedInstance: Marketo = Marketo.sharedInstance() sharedInstance.initialize(withMunchkinID: Configs.MARKETO_ID, appSecret: Configs.MARKETO_SECERT_KEY, launchOptions: launchOptions)
Crashing log:
At [Marketo initializeWithMunchkinID:appSecret:launchOptions:] thread:
Screenshot 2022-09-12 at 10 42 16

Cannot Initialize Marketo iOS SDK

Hi all, I am running into an issue of where I cannot connect to the SDK. This is our first time connecting to Marketo via iOS app, with munchkin id 824-XEX-790. I read other issues raised, saying that the provisioning profile is not set up fully? Would someone here be able to confirm as I am grabbing my ID and Key directly from the Marketo Console. We are also using Sandbox environment.

2022-01-11 09:19:51.482249-0600 MarketoFramework--[MKTNetworkManager getDataFromEndpoint:] [Line 52] Getting data from end point https://824-XEX-790.mktomma.com/api/v1/sync/N0tNZTJzd21pam52QXpUUlN0T0k4MWt1?lst=0 2022-01-11 09:19:51.482534-0600[47632:732805] MarketoSDK-Current UUID is : 3A67E8DB-5655-4F33-BBF8-0A24DB56C3BC 2022-01-11 09:19:52.565540-0600 [47632:732805] MarketoSDK-The certificate for this server is invalid. You might be connecting to a server that is pretending to be “824-xex-790.mktomma.com” which could put your confidential information at risk. 2022-01-11 09:19:52.566026-0600 [47632:732805] MarketoFramework--[MKTEventLogger reportEvents:] [Line 153] Marketo is not initlized 2022-01-11 09:19:53.464053-0600 [47632:732404] MarketoSDK-[warning] is not initialized. Initialize Framwork using initializeWithMunchkinID:appSecret: method. 2022-01-11 09:19:53.493734-0600[47632:732860] MarketoFramework--[MKTEventLogger reportEvents:] [Line 153] Marketo is not initlized

InApp Message Event

Could you please add InApp Message Event like on showing,on dismissing, etc ?

Push Notification Deep Link not working

Dear Marketo,
I'm Michael, iOS Developer. I have implemented Market Push Notification and the notification works. I have one Issue that I want to ask.

I put custom link (my app deep link) on push notification. I've already set the URL Type on Info section in X-Code with format mkto-AppSecretKey (Please find the screenshot below).However when I click the notification, I get Log from MarketoSDK.

"MarketoSDK-Deep link received but mkto url scheme not found."

Could you help me with the issue ?

Regards,

Michael
screenshot 2017-06-12 13 58 30

Define dictionary key constants

On MarketoActionMetaData there is an actionMetadata property, but no keys are given. In the Marketo.h file, some examples are given such as "Action Type". Please make these constants to give better documentation and avoid typos.

Example:

header: extern NSString *const MKTActionType;
implementation: NSString *const MKTActionType = @"Action Type";
usage: @{MKTActionType: @"Shopping"}

Profile Updates

Hey all,

I am curious to see what the correct behavior should be? I am trying to update an existing profile's email address, should that update the existing record or does updating a profile's email cause a new profile to be created?

Thanks,

App crashing issue

Hi team,

We have using the PhoneGap ionic cordova plugin https://github.com/Marketo/PhoneGapPlugin

recently the plugin get update (IOS framework update) after we are facing app crash issue once build for more info, I shared crash report.

please fix this issue update the PhoneGap plugin IOS https://github.com/Marketo/PhoneGapPlugin

Hardware Model: iPhone12,1
Process: xxx
Path: /private/var/containers/Bundle/Application/77D141E8-5791-4392-B6FA-278BAA6485D1/xxx.app/xxx
Identifier: xxx
Version: 2.0.4 (2.0.4)
Code Type: ARM-64 (Native)
Role: Foreground
Parent Process: launchd [1]
Coalition: xxx.xxx.xxx [768]

OS Version: iPhone OS 16.0 (20A362)
Release Type: User
Baseband Version: 4.00.00
Report Version: 104

Exception Type: EXC_CRASH (SIGABRT)
Exception Codes: 0x0000000000000000, 0x0000000000000000
Termination Reason: DYLD 1 Library missing
Library not loaded: @rpath/MarketoFramework.framework/MarketoFramework
Referenced from: <26FCB2AD-1B0D-3B26-8883-B5311671499F> /Volumes/VOLUME/*/xxx.app/xxx
Reason: tried: '/usr/lib/swift/MarketoFramework.framework/MarketoFramework' (errno=2, not in dyld cache), '/private/preboot/Cryptexes/OS/usr/lib/swift/MarketoFramework.framework/MarketoFramework' (errno=2), '/private/var/containers/Bundle/Application/77D141E8-5791-4392-B6FA-278BAA6485D1/xxx.app/Frameworks/MarketoFramework.framework/MarketoFramework' (errno=2), '/usr/lib/swift/MarketoFramework.framework/MarketoFramework' (errno=2, not in dyld cache), '/private/preboot/Cryptexes/OS/usr/lib/swift/MarketoFramework.framework/MarketoFramework' (errno=2), '/private/var/containers/Bundle/Application/77D141E8-5791-4392-B6FA-278BAA6485D1/xxx.app/Frameworks/MarketoFramework.framework/MarketoFramework' (errno=2), '/private/preboot/Cryptexes/OS@rpath/MarketoFramework.framework/MarketoFramework'
(terminated at launch; ignore backtrace)

Triggered by Thread: 0

Thread 0 Crashed:
0 dyld 0x1eb463e08 __abort_with_payload + 8
1 dyld 0x1eb46d574 abort_with_payload_wrapper_internal + 104
2 dyld 0x1eb46d5a8 abort_with_payload + 16
3 dyld 0x1eb4116b4 dyld4::halt(char const*) + 328
4 dyld 0x1eb40f92c dyld4::prepare(dyld4::APIs&, dyld3::MachOAnalyzer const*) + 4092
5 dyld 0x1eb40d8bc start + 2364

Thread 0 crashed with ARM Thread State (64-bit):
x0: 0x0000000000000006 x1: 0x0000000000000001 x2: 0x000000016bb5ac30 x3: 0x00000000000000a7
x4: 0x000000016bb5a830 x5: 0x0000000000000000 x6: 0x0000000000000000 x7: 0x0000000000000e20
x8: 0x0000000000000020 x9: 0x0000000000000009 x10: 0x0000000000000001 x11: 0x000000000000000a
x12: 0x0000000000000000 x13: 0x0000000000000032 x14: 0x000000025e6b3e39 x15: 0xffffffffffffffff
x16: 0x0000000000000209 x17: 0x00000001eb460708 x18: 0x0000000000000000 x19: 0x0000000000000000
x20: 0x000000016bb5a830 x21: 0x00000000000000a7 x22: 0x000000016bb5ac30 x23: 0x0000000000000001
x24: 0x0000000000000006 x25: 0x000000016bb5b518 x26: 0x0000000000000001 x27: 0x0000000000000000
x28: 0x00000002240149c0 fp: 0x000000016bb5a800 lr: 0x00000001eb46d574
sp: 0x000000016bb5a7c0 pc: 0x00000001eb463e08 cpsr: 0x00000000
far: 0x00000002240154b0 esr: 0x56000080 Address size fault

Binary Images:
0x1eb3f8000 - 0x1eb47ae4f dyld arm64e <341bbf646034357e8aa6e1e4b988e03c> /usr/lib/dyld

EOF

UILocalNotification Deprecated

Hello, please update the SDK to support iOS 10 and above projects.

../Pods/Marketo-iOS-SDK/Marketo.framework/Headers/Marketo.h:110:79: error: 'UILocalNotification' is deprecated: first deprecated in iOS 10.0 - Use UserNotifications Framework's UNNotificationRequest [-Werror,-Wdeprecated-declarations]

Crashing do to privacy violation

Hello,

I just included your SDK in my app, and almost immediately saw a spike in crashes. After digging through threads in Bugsnag and Xcode, I found that the cause appears to be your SDK. Each of the crashes has a thread like this:

#0	(null) in semaphore_wait_trap ()
#1	(null) in _dispatch_sema4_wait$VARIANT$armv81 ()
#2	(null) in _dispatch_semaphore_wait_slow ()
#3	(null) in CFURLConnectionSendSynchronousRequest ()
#4	(null) in +[NSURLConnection sendSynchronousRequest:returningResponse:error:] ()
#5	0x0000000105073440 in -[MKTNetworkManager postDataSync:toEndpoint:] ()
#6	0x0000000105069af0 in __31-[MKTEventLogger reportEvents:]_block_invoke ()
#7	0x000000010507998c in -[MKTDataManager getEventsDataWith:] ()
#8	0x00000001050699c8 in -[MKTEventLogger reportEvents:] ()
#9	0x0000000105064b98 in __60-[Marketo initializeWithMunchkinID:appSecret:launchOptions:]_block_invoke ()
#10	(null) in _dispatch_call_block_and_release ()
#11	(null) in _dispatch_client_callout ()
#12	(null) in _dispatch_queue_serial_drain$VARIANT$armv81 ()
#13	(null) in _dispatch_queue_invoke$VARIANT$armv81 ()
#14	(null) in _dispatch_root_queue_drain_deferred_wlh$VARIANT$armv81 ()
#15	(null) in _dispatch_workloop_worker_thread$VARIANT$armv81 ()
#16	(null) in _pthread_wqthread ()
#17	(null) in start_wqthread ()

Can you please advise?

MarketoSDK-Cannot connect to Marketo.

Hi,

We are trying to integrate Marketo SDK in iOS & Android app. After following the documentation from Marketo team - https://docs.marketo.com/display/public/DOCS/Add+a+Mobile+App

We have added all the necessary code in our mobile apps with the generated - Munchkin Account Id & Secret Key. But we are still facing issues and can see these error logs -

MarketoSDK-Cannot connect to Marketo.
MarketoFramework--[MKTEventLogger reportEvents:] [Line 153] Marketo is not initlized

After looking for the issue we landed up on below mentioned link -
#18

Which seems to have similar case as ours. We are also trying to integrated Marketo in our apps for the first time.

Could you please help us with the issue.

Thanks

Allow MarketoLead() to set MarketoID or PersonID

Hi,

Currently we are able to associate a lead using email as follows:

let profile = MarketoLead() 
profile?.setEmail(user.email) 
Marketo.sharedInstance()?.associateLead(profile)

But this would create a NEW PERSON activity for this user.

Are we able to add an option for us to set the Person ID so we don't misleadingly send this NEW PERSON activity type?

For example:
let profile = MarketoLead()
profile?.setProfileId(user.id)
Marketo.sharedInstance()?.associateLead(profile)

Regards,
Kai

Use @import instead of #import

When I drop the SDK into a brand new project and try to build, I get linker errors. The SDK is using Core Data and the Core Telephony frameworks, and the project needs to have them linked to build. Replacing import statements that were #import with @import should resolve that issue and link them in automatically (though I'm not sure if that applies with frameworks too).

Apple silicon support

Currently Marketo-iOS-SDK doesn't fully support Apple silicon. Version 0.8.0 excludes the arm64 architecture which forces the Simulator to run x86_64, which means the entire app will have to compile for x86_64. That's problematic when we have other dependencies because they (correctly) only compile for the active architecture for DEBUG mode which is arm64 on Apple silicon. To workaround that, we have to force all of our dependencies to build for both x86_64 and arm64 via ONLY_ACTIVE_ARCH = NO. With that, you may be able to run the app with Xcode not using Rosetta but the Simulator will be using Rosetta. However, if you have any dependencies installed via Swift Package Manager, it's seemingly not possible to force those to build for both architectures, and thus the app won't compile on Apple silicon.

Do you have an ETA when you'll stop excluding arm64 and fully support Apple silicon?

unregisterPushDeviceToken crashes app

We are seeing a good number of crashes when Marketo.sharedInstance().unregisterPushDeviceToken() is called. It seems to only be impacting iOS 15 users from the crash reports we've received. We are using the latest iOS 15 SDK with the current version of Xcode and version 0.7.8 of Marketo.

Thread 0 name:
Thread 0 Crashed:
0   libsystem_kernel.dylib        	0x00000001b8b48540 semaphore_wait_trap + 8
1   libdispatch.dylib             	0x000000018181bbf0 _dispatch_sema4_wait + 28 (lock.c:139)
2   libdispatch.dylib             	0x000000018181c2a8 _dispatch_semaphore_wait_slow + 132 (semaphore.c:132)
3   CFNetwork                     	0x000000018239f4d0 CFURLConnectionSendSynchronousRequest + 380 (CFURLConnection_Synchronous.c:209)
4   CFNetwork                     	0x000000018244a268 +[NSURLConnection sendSynchronousRequest:returningResponse:error:] + 120 (NSURLConnection.mm:480)
5   OurApp                        	0x000000010304ed1c -[MKTNetworkManager postDataSync:toEndpoint:] + 500 (MKTNetworkManager.m:146)
6   OurApp                        	0x0000000103042460 __31-[MKTEventLogger reportEvents:]_block_invoke + 444 (MKTEventLogger.m:201)
7   OurApp                        	0x00000001030572c0 -[MKTDataManager getEventsDataWith:] + 876 (MKTDataManager.m:104)
8   OurApp                        	0x0000000103042250 -[MKTEventLogger reportEvents:] + 920 (MKTEventLogger.m:178)
9   OurApp                        	0x000000010303ef7c -[Marketo unregisterPushDeviceToken] + 132 (Marketo.m:661)

MarketoSDK-Cannot connect to Marketo.

Hi,

I tried reaching out to Marketo team via our account manager earlier(#21) and got to know that Mobile facility is provisioned and enabled in our account however I keep getting error I listed earlier.

Here is my Munchkin Id -> 822-DNR-415

Thanks

App cannot be run on Simulator due to lack of Apple silicon support

On a Mac with Apple silicon, you cannot build and run an app that has Marketo integrated on the Simulator because Marketo does not support Apple silicon with the current version 0.7.8.

platform :ios, '13.0'

target 'Test' do
use_frameworks!

pod 'Marketo-iOS-SDK'

end

It'll install on the Simulator but will not open and Xcode presents this error alert:

Application launch for 'com.mydomain.Test' did not return a valid pid nor a launch error.
Domain: NSPOSIXErrorDomain
Code: 3
Failure Reason: No such process
User Info: {
    DVTErrorCreationDateKey = "2022-10-10 16:14:56 +0000";
    IDERunOperationFailingWorker = IDELaunchiPhoneSimulatorLauncher;
}

M1 Mac / Arm64 support required

We're unable to build our project which relies on the Marketo-iOS-SDK on M1 Macs targeting running on Simulator. Error is:

ld: in /Users/username/projectpath/ios/Pods/Marketo-iOS-SDK/Marketo.framework/Marketo(Marketo.o), building for iOS Simulator, but linking in object file built for iOS, file '/Users/username/projectpath/Pods/Marketo-iOS-SDK/Marketo.framework/Marketo' for architecture arm64

Please add support for building on new Macs!

MarketoSDK-Cannot connect to Marketo

Trying to call initializeWithMunchkinID but got this in the logger.

2019-07-31 16:27:47.037556-0700 example[14793:1263107] MarketoFramework--[MKTNetworkManager getDataFromEndpoint:] [Line 52] Getting data from end point https://XXX.mktomma.com/api/v1/sync/XXXX?lst=0
2019-07-31 16:27:47.037930-0700 example[14793:1263107] MarketoSDK-Current UUID is : 9A762E63-49F3-4CA3-AA7F-77C6D86961B9
2019-07-31 16:27:47.048399-0700 example[14793:1263083] TIC TCP Conn Failed [3:0x600002389ec0]: 12:8 Err(-65554)
2019-07-31 16:27:47.053546-0700 example[14793:1263083] Task <E218C999-4C48-485B-916E-A0A1E55130BB>.<0> HTTP load failed (error code: -1003 [12:8])
2019-07-31 16:27:47.054586-0700 example[14793:1263083] NSURLConnection finished with error - code -1003
2019-07-31 16:27:47.055272-0700 example[14793:1263107] MarketoSDK-Cannot connect to Marketo.
2019-07-31 16:27:47.055454-0700 example[14793:1263107] MarketoFramework--[MKTEventLogger reportEvents:] [Line 153] Marketo is not initlized

Do not receive push notifications when re-registering

Hi team,
I am writing a native ios module for react native.
When the user logs in for the first time, I call the function:

  • initializeWithMunchkinID
  • registerPushDeviceToken
  • associateLead

When the user logs out, I call the function:

  • unregisterPushDeviceToken

But when the user re-login, I call these functions:

  • initializeWithMunchkinID
  • registerPushDeviceToken
  • associateLead
    but do not receive push notifications.

Please help me, thanks

Xcode 10 Project Configuration Issue

I am receiving the following error when trying to build with Xcode 10:

Multiple commands produce '/Users/jaxon/Library/Developer/Xcode/DerivedData/iosV3-gywaxzycanbudohjfidzhliwkjlb/Build/Products/Debug-iphonesimulator/Marketo-iOS-SDK/MKTResources.bundle/Info.plist':
1) Target 'Marketo-iOS-SDK-MKTResources' (project 'Pods') has copy command from '/Users/jaxon/iosV3/Pods/Marketo-iOS-SDK/ResourcePod/Info.plist' to '/Users/jaxon/Library/Developer/Xcode/DerivedData/iosV3-gywaxzycanbudohjfidzhliwkjlb/Build/Products/Debug-iphonesimulator/Marketo-iOS-SDK/MKTResources.bundle/Info.plist'
2) Target 'Marketo-iOS-SDK-MKTResources' (project 'Pods') has process command with output '/Users/jaxon/Library/Developer/Xcode/DerivedData/iosV3-gywaxzycanbudohjfidzhliwkjlb/Build/Products/Debug-iphonesimulator/Marketo-iOS-SDK/MKTResources.bundle/Info.plist'

According to this stack overflow discussion (https://stackoverflow.com/questions/50718018/xcode-10-error-multiple-commands-produce) the issue is related to the way that Xcode 10 looks for project configuration issues.

The solution of changing from New Build System to Legacy Build System suggested by several users does fix the issue, but isn't a good long term solution.

Marketo is not initialized

Hi all, I am running into an issue of where I cannot connect to the SDK. This is our first time connecting to Marketo via iOS app, with munchkin id 824-XEX-790. I read other issues raised, saying that the provisioning profile is not set up fully? Would someone here be able to confirm as I am grabbing my ID and Key directly from the Marketo Console. We are also using Sandbox environment.

Open Source Framework

It would be really nice to see the source code of the framework, to create pull requests and help to make it better overall. I would have submitted issue #1 as a pull request instead of an issue if this was the case. I could have also verified that the fix worked. It would be great to see you guys take this step.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.