markocen / ngpopup

[DEPRECATED] An Angular modaless dialog, without jQuery dependency , super easy to use, and has fully customized theme.

Hi there 👋

ngpopup's Issues

A Version for Angular 2

Hi,
Do you have any plan in recent days to make some updates of this great tool to angular 2 version?

bower register missing

Any plans to registerd ngPopup with Bower? Cannot be used with bower dependencies in larger projects.

Resize and z-index

Hi,

1. when trying to resize on left corner or right corner - the dialog stuck on resize action without option to stop resizing. Only restart of browser helps to stop resizing.
2. Can the dialog be on top of all controls?
   

How do you trigger the popup with a scope variable/data?

The documentation is incomplete. I had a hard time just to trigger the popup on clicking a link. I still can't figure out how to trigger it. Your example doesn't state that. Please can you guide?

Dragging proposed fix

Moved mouseup from element to document (like mousemove). There are times when element mouseup will not be received (e.g., scrollbar is showing for content).

ngPopup.zip

Thanks!

Passing values to ngPopup template

I have to pass some of the values from parent controller to ngPopup template controller . Please let me know the best way to do .

Open on button click

Hi
Is there anyway we can open on button click ? Is there any service created ?

Dragging window on ngPopup demo causes it to shrink

This is very odd bahviour, seen in both Firefox and Chrome

Dragging has some issue

If you drag the popup, it doesn't let go the cursor. Basically, you aren't able to click on the parent page.

Package.json and bower.json version tags do not match release tag

For release tag 0.4.0

the package.json file shows:
"version": "0.1.2",

the bower.json shows:
"version": "0.3.0",

Please update these accordingly,

Thank you

Drags issues

Hi,

I checked that if you right click in the popup, it starts dragging and you can not stop it.

I just added this to the self.mouseDownHandler function (in ngPopup.js) to stop that behaviour.

---

At the start of the function:
if(event.button ==2) return;

Thanks

template not found with templateUrl

I am trying to load teamplate using templateUrl. But I am getting 404 template not found error. Code is below
self.ngPopupOption = {
isShow: false,
modelName: "myNgPopup",
width: 500,
height: 400,
hasTitleBar: true,
templateUrl: "chat-content.html",

File 'chat-content.html" is located in the same location as this file. Also, I am using browsyfy for minification which creates template cache like [run(["$templateCache", function($templateCache) {$templateCache.put("src/chat-modal/chat-content.html"]

And in min file the above code looks like this
self.ngPopupOption = {
isShow: false,
modelName: "myNgPopup",
width: 500,
height: 400,
hasTitleBar: true,
templateUrl: "src/chat-modal/chat-content.html",

Could someone help in finding what mistake I am doing?

General issues: drags, events etc

Hi,
The Demo is based on the YT embeded content (iframe), the mouse propagation is off for this window. To make it working:

//event.buttons == 0 mouse is not pressed
if (event.buttons == 0) self.mouseUpHandler(event);

must be added in mouse move handlers ( This is it to fake/trigger UP event ).

When the

This is still great component.

Krzys

can't import 'ng-popup'

I am using webpack, and tried to import ng-popup like this after I installed via npm:

import 'ng-popup';

However, the webpack complained

ERROR in ./client/app/app.js
Module not found: Error: Cannot resolve module 'ng-popup' in /Users/jinbo/dev/mvp/client/app
@ ./client/app/app.js 125:0-19

Anyone has insight on what might be the problem?

Thanks

populate popup content using angularjs?

Hi,
Looking at using your library (thanks!), and I wanted to share what I how I wanted to use it since it doesn't appear to support using it this way.

I would like to populate the popup content using a div from my html document . The contents of the div would actually be coming from a controller/scope in angularjs.

i.e. how can I display "popupcontent" in the popup?

<ng-pop-up option='ngPopupConfig'></ng-pop-up>
<div id="popupcontent">
Hi, my name is Phillip
</div>

Thanks again,
Phillip

popup keeps growing

i have an issue where the popup keeps growing due to an inconsistency in the width as set using style.width and the value returned via offsetWidth. They differ slightly causing the window to grow (and performance in general to suffer due to a feedback loop)

updateParentScopeOptions: function(options,element){
            var $element = element[0];
            options.position.left = $element.offsetLeft;
            options.position.top =  $element.offsetTop;

            if($element.getElementsByClassName('content')[0].style.display != 'none'){
                 options.width = $element.offsetWidth; // <-- offsetWidth is slightly larger than the originally set offset.width
                 options.height = $element.offsetHeight;
             }
        }

updateElementSize: function(...){
...
     $element.style.width = width;
...

Created a branch to fix dragging issues

Hi,

I have created a branch incorporating a fix created by another user and have tested it, and would like to merge it into the source.

Aaron

Can we use this directive ngPopup to open multiple dialog with one directive only

Hi

i have been trying to use this directive to build a chat functionality and wanted to open multiple dialogs for different chat session for different users.

i added directive one time in to the HTML and also tried to add directive at run time

Please suggest how can we achieve this functionality using this directive.

Regards,
Hemant Jindal