martinandert / react-interpolate-component Goto Github PK

The reason I am asking is that I want to use react-addons-test-utils that is provided in [email protected] and I cannot upgrade mine to rc1 as I use yours that is constrained by 0.13

Hi,

When I use React-translate-component and the resource value is an empty string
The underlying interpolate component throws a Interpolate expects either a format string as only child or a 'format' prop with a string value error

this is because

this.props.children || this.props.format --> results in undefined
example:
"" || undefined => undefined

see: https://github.com/martinandert/react-interpolate-component/blob/master/index.js#L22

Is this expected behavior?

with kind regards,

Ronald van der Kooij

I like your react component and the idea of a interpolate field. Would you accept a PR or thing it feasible to add additional template bracketing support

The component triggers a React deprecation warning with React versions greater than v15.5.0:

Warning: Interpolate: React.createClass is deprecated and will be removed in version 16. Use plain JavaScript classes instead. If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement.

See https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html for more information.

I was trying to upgrade a react-app create using node v14 and react v14 to react v17 and node v18. The react-interpolate only accepts react v16, so on running npm install I am facing dependency resolution issues. Can the application be upgraded to accept react v17 or if I can collaborate to the project for the same?

carrying on from: martinandert/react-translate-component#21

It would be good to know if this was caused by the interpolate component

thanks