martinmroz / ihex Goto Github PK

I believe it is swapped here.
The calculated one should be the value to be expected.

Using this package with hex files that were created on a windows system (\r\n line ending) results in RecordNotEvenLength errors.

• Switch to FromStr for parsing individual record strings.
• Add impl FusedIterator for Reader.

I am trying to use ihex for some hex analysis and I wanted to get a Display implementation for Record, while messing around with it, I got this error:

error[E0277]: a value of type `std::result::Result<std::vec::Vec<std::string::String>, writer::WriterError>` cannot be built from an iterator over elements of type `std::string::String`
   --><MYDIR>/ihex/src/writer.rs:192:10
    |
192 |         .collect::<Result<Vec<String>, WriterError>>()
    |          ^^^^^^^ value of type `std::result::Result<std::vec::Vec<std::string::String>, writer::WriterError>` cannot be built from `std::iter::Iterator<Item=std::string::String>`
    |
    = help: the trait `std::iter::FromIterator<std::string::String>` is not implemented for `std::result::Result<std::vec::Vec<std::string::String>, writer::WriterError>`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0277`.
error: could not compile `ihex`.

I don't have enough Rust experience to fix this yet, so posting hoping one of the contributors have an idea of a fix.

Hi,

Not sure if this is still relevant, but from the wikipedia page of the Intel hex file format it is mentioned that all characters preceding the start code of a record should be ignored, which is not the case as of today. I have done a modification on my fork to do this, but I wanted to know if this is still relevant before doing a PR.

Would you consider making it dual licensed to MIT OR Apache-2.0? Reasons have been discussed fully i.e. lo48576/fbx_direct#1

Thanks for creating this awesome crate!

Hi,

Thank you for this usefull crate in a niche domain :D

Is it possible to bubble up any parsing error so we can inform the user that something gone wrong?

pub struct MemoryRegion {
    pub start: u32,
    pub end: u32,
    pub name: String,
    pub buffer: Vec<u8>,
}

impl MemoryRegion {
    fn address_in_region(&self, address: u32) -> bool {
        address >= self.start && address <= self.end
    }

    fn set(&mut self, address: u32, value: u8) {
        let offset = (address - self.start) as usize;
        self.buffer[offset] = value;
    }

    fn get(&self, address: u32) -> u8 {
        let offset = (address - self.start) as usize;
        self.buffer[offset]
    }

    fn to_ihex(&self) -> String {
        let mut data: Vec<u8> = vec![];
        for i in (self.start..self.end) {
            data.push(self.get(self.start + i));
        }
        let offset = (self.start >> 16) as u16;
        return ihex::create_object_file_representation(&[
            ihex::Record::ExtendedSegmentAddress((self.start >> 16) as u16),
            ihex::Record::Data { offset, value: data },
            ihex::Record::EndOfFile,
        ]).unwrap();
    }
}

I'm trying to dump this MemoryRegion:

MemoryRegion {
                start: 0x50000000,
                end: 0x5001DFFF,
                buffer: vec![0; 0x1E000],
                name: String::from("CPU2_DSPR"),
            }

and I'm a little confused how I should be doing the looping given the constraints from ihex::Record::Data (Specifies a 16-bit offset address and up to 255 bytes of data)

Can you maybe help me better understand what it would take to dump this memory region and maybe we can PR it to the README for a stronger, more real world Intel hex example?