Parsec parsers that are not implemented about combine

[jxv]

WIth oneOf, noneOf, char, and count functions above. They take some non-parsec-transformer value as an arg to curry a new function with that value in its environment. Now, should there be way to generalize the capture with a struct and a function?

Take this gist for example:

// F: Fn(E,A,P) -> B
 struct Capture<E,A,B,P,F> {
    env: E,
    parser: P,
    func: F
}

[Marwes]

I sketched out something like the Capture struct when helping giving help in the reddit post. Still, I think the bigger issue is with the oneOf and nonOf functions of what type of argument they should take. With slices they are efficient but bound to a lifetime and a Vec forces allocation. The Cow type could allow for both but forces an additional overhead. I am not sure what is the best approach here.

[jxv]

In regards to the Cow type's overhead. (I don't know how much it has). Why not implement both approach but as separate structs/functions? Eg. OneOfVec/one_of_vec and OneOfSlice/one_of_slice.

[Marwes]

I think Cow should just be an extra 8 bytes for the tag (so 24 bytes for Vec + 8 = 32 bytes) vs 16 bytes for only a slice. I don't believe that there should be any branch overhead for the usage though, since the slice and Vec type both have their pointer and length at the same location in memory.

There is also the option of going even more generically by using some trait which can be implemented for any sort of collection though since the collection traits where removed from the standard library it is probably necessary to define it in the library which seems like overkill.

[tailhook]

It seems I need sepEndBy, because I'm tired of trailing comma issue. Is it hard to implement?

[Marwes]

It shouldn't be particularly hard to implement if feel free to give it a go if you want. If you look at the sepBy parser it should get you most of the way though it is a bit more complex than it needs to be. I can take a look later this week otherwise.

[Marwes]

sep_end_by and sep_end_by1 were added in 7ae8d32

[tailhook]

@Marwes works fine. Thanks a lot!

[Marwes]

eof added in 1.3.0

[Marwes]

Closing since all relevant parsers have presumably been added by now. If a parser is still missing then just open a new issue!