GithubHelp home page GithubHelp logo

Comments (4)

nejucomo avatar nejucomo commented on July 20, 2024

Ah, I used to be generic over the stream type, but elsewhere I followed an example for the then docs that had this snippet:

// Force input to be a &str
let _: &str = input;

This is with 2.0.0-beta.

from combine.

Marwes avatar Marwes commented on July 20, 2024

It appears that Parser is only implemented for FnMut not Fn which I believe is why that does not just work. That being said it is not really needed (at least in this case), an easier way of writing that would be.

// Fn -> Parser
pub fn keyword(kw: &'static str) -> Box<Parser<Input = &str, Output = ()>
{
    use combine::{ParserExt, string, value};

    assert!(KEYWORDS.contains(&kw));

// Remove the closure
    Box::new(string(kw)
            .with(value(())))
}

Just be aware that boxing incurs a runtime cost (allocation + indirection) so if you want the best performance you should avoid it as much as possible (once rust-lang/rust#35091 becomes stable creating higher order parsers should be much more convenient as well!).

from combine.

nejucomo avatar nejucomo commented on July 20, 2024

Thanks, this indeed fixes all type errors. This is my first use of a trait object.

from combine.

Marwes avatar Marwes commented on July 20, 2024

Happy to be of help!

from combine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.