GithubHelp home page GithubHelp logo

Comments (4)

Marwes avatar Marwes commented on July 20, 2024

Something like this should work for &str.

parser(|input: &str| {
    let mut iter = input.graphemes();
    match iter.next() {
        Some(g) => {
            // Since we have consumed something to get to this point we need tell the caller this so it knows
            // whether to try other alternatives (if this errors later on)
            Ok((g, Consumed::Consumed(iter.as_str()))
        }
        None => Err(ParseError::end_of_input()),
    }
})

For a more generic parser I think that we need to at least limit the parser to RangeStream<Range = &str> since that will give the &str type which unicode segmentation needs. Its current implementation does not support that case however.

I am thinking that maybe I can add another method to Rangestream as below.

// `remaining` returns the entire remaining range which can be inspected letting one determine
// the length one need to pass to `uncons_range`
fn remaining(&self) -> Self::Range;

How to properly construct the error

There is really nothing special about any of these. expected just indicates what the parser expected to find and unexpected indicates what the parser actually found but ended up rejecting. Info is just somewhere to store the information, none of the variants have any special meaning. Usually only expected errors are necessary as unexpected are created automatically from the Stream.

from combine.

jan-hudec avatar jan-hudec commented on July 20, 2024

I was not asking for help, I was suggesting you enhance the documentation. The response is not useful here (I've already decided I am not rewriting the nom thing). It would be somewhat useful in the documentation though—as long as you improve documentation of ParseError—I see all of 2 lines for the struct and nothing for most methods.

from combine.

Marwes avatar Marwes commented on July 20, 2024

Ok. ParseErrors methods are only really used internally so it to have slipped through the cracks. I will add a bit more though.

from combine.

jan-hudec avatar jan-hudec commented on July 20, 2024

Well, but it's what one comes at when looking up the return type. So you either need to document them there, or you need to put a documentation somewhere up the chain describing how to create errors—which would mean in ParseResult, because there the error type is directly Consumed<ParseError<I>>. The wrapping of ParseError in Consumed is already something that needs explanation.

from combine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.