GithubHelp home page GithubHelp logo

marwinburesch / moviescout Goto Github PK

View Code? Open in Web Editor NEW
4.0 2.0 13.0 713 KB

Movies for days

Home Page: https://www.figma.com/file/q0Ba6NvbLTWLfnm962toMg/Movies-discovery-mobile-app-(ytsXmovies)-(Community)?node-id=0%3A1

Shell 0.22% JavaScript 1.19% TypeScript 84.98% HTML 0.58% CSS 13.03%

moviescout's People

Contributors

marwinburesch avatar christianseelemann avatar phlgr avatar dimas1976 avatar benfielmann avatar rickkollenbroich93 avatar seborider avatar christophschmitz avatar leonie-bu avatar yoocly avatar

Stargazers

 avatar Dani avatar  avatar  avatar

Watchers

James Cloos avatar  avatar

moviescout's Issues

Bookmarks page is hardcoded

We've recently added the useLocalStorage hook, now it's time to implement it for the bookmarks. Ideally, we want to store the user's bookmarks in localStorage as a list of ids of movies and fetch once the user gets to the page. If there aren't any bookmarks, we should display at least a message saying so.

After some thoughts, it would probably be best practice to have a dedicated API endpoint for fetching a list of movies based on a list of ids.

Deployment seems to fail due to `id`

Property 'id' is missing in type '{ children: string; layout: "detail"; title: string; rating: number; genres: string[]; image: string; onBookmarkClick: () => void; }' but required in type 'CardProps'.

RatingIcon `key` prop isn't set

We get this error on visiting /

Warning: Each child in a list should have a unique "key" prop.

Check the render method of `Rating`. See https://reactjs.org/link/warning-keys for more information.
    at RatingIcon (http://localhost:3000/src/app/components/RatingIcon/RatingIcon.tsx:19:3)
    at Rating (http://localhost:3000/src/app/components/Rating/Rating.tsx:20:3)
    at div
    at section
    at article
    at Card (http://localhost:3000/src/app/components/Card/Card.tsx:21:3)
    at section
    at div
    at div
    at Home (http://localhost:3000/src/app/pages/Home/Home.tsx:98:41)
    at Route2 (http://localhost:3000/node_modules/.vite/chunk-ZAVVHJXD.js?v=b286ad33:1729:29)
    at Switch2 (http://localhost:3000/node_modules/.vite/chunk-ZAVVHJXD.js?v=b286ad33:1873:29)
    at Router2 (http://localhost:3000/node_modules/.vite/chunk-ZAVVHJXD.js?v=b286ad33:1455:30)
    at BrowserRouter2 (http://localhost:3000/node_modules/.vite/react-router-dom.js?v=b286ad33:54:35)
    at App

The error describes how the stack collapsed. More about that here

User Profile

User Story

As a user
I want to have a profile
so I can have a centralized place for all my details

Description / Notes

details details details

Screenshot / Design

Acceptance Criteria

  • Avatar
  • Edit button
  • etc.

Inconsistent use of `export default`

Sometimes a component is exported right at the function declaration, sometimes at the end of the file.

We decided to have components and pages exported right at the function declaration.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.