masakudamatsu / colmar_academy Goto Github PK

It's better to work on the header for both mobile and desktop screens at once.

In response to #21

One thing that really stood out to me was how well organized and commented the CSS was. It made it really easy to understand and evaluate. 🌟

If you're looking to take your CSS organization to the next level, I love the BEM method http://getbem.com/introduction/

Add role="presentation" and aria-label where appropriate.

This extra margin stood out when I was looking in Chrome dev tools responsive mode (https://developers.google.com/web/tools/chrome-devtools/device-mode/emulate-mobile-viewports) :

One thing I would look into is either making the breakpoint move from mobile to desktop sooner for this section or making the items stretch to fill the whole screen

Based on this concept, we will choose the color palette and typefaces.

Great job going above and beyond making this website accessible with the aria attributes and descriptive alt tags. That's a great habit to get into. It makes your websites usable for disabled people, is important for search engine optimization, and is now legally required in many places. 🌟

Currently, the button color is darker than its surrounding, making the button less noticeable as a button. Choose the color lighter than the surrounding.

Also decide the background-color and color for hover and active.

Study how the video tag works.

Currently for the width less than 1200px, the banner text is relatively too big compared to the scaled-down image size.

Hi, I'm reviewing for codecademy. Amazing job on this! You went so far above and beyond, I am very impressed. It looks great and is very responsive.

I'll file a few issues with some things that stood out to me.

Also congrads on finishing the course! I hope you go on to make lots of great websites like this.

I wouldn't recommend hiding the video controls because some browsers block autoplay now so then they would be unable to play the video.

Typeface for course names has to be reconsidered.

Accessibility Developer Guide argues that there is no need to add role="presentation" in any cases.

• Screen readers won't read up div or span anyway, according to Accessbility Developer Guide.