GithubHelp home page GithubHelp logo

jammming's People

Contributors

dependabot[bot] avatar masakudamatsu avatar mkudamatsu avatar

jammming's Issues

Add Song to a Custom Playlist

users can add a track to their playlist by selecting a + sign on the right side of the track’s display container.

Feature Request Summary

Rubric Score

Criteria 1: Objective Section

  • Score Level: 4 (exceeds expectations)
  • Comment(s): Short but clear, good

Criteria 2: Background Section

  • Score Level: 4
  • Comment(s): Explains the background well and explains why this feature is needed, no issues here

Criteria 3: Technical Design Section

  • Score Level: 4
  • Comment(s): Technical design is very well thought out, even explaining specifically which libraries and icons it will use, great!

Criteria 4: Caveats Section

  • Score Level: 3 (meets expectations)
  • Comment(s): Caveats are well done and consider possible issues thoroughly. One big caveat to any web application is error handling which should be discussed a bit. Adding music playback adds some issues if the music does not load successfully, for example.

Overall Score: 15/16

Overall this is very excellently done. The technical design specifically is very well considered and planned. Great Job! Keep up the good work and happy coding!

Overall Summary

Criteria 1: App Creation, Folder Structure, and File Paths

  • _Score Level: 4/4
  • _Comment(s): You had all the right files and folder. Good job.

Criteria 2: Correct Implementation of User Flows (e.g. Searching, Token Generation, Save Playlist, etc.)

  • _Score Level: 4/4
  • _Comment(s): Nice job conquering this part of the project! You used requests correctly and made the right API calls to the Spotify API.

Criteria 3: Proper JavaScript and JSX Syntax and Formatting

  • _Score Level: 4/4
  • _Comment(s): You show a clear understanding of the React fundamentals. Great job using props, binding methods, passing props, rendering children and more. Your indentation was off in a few places. Make sure you lookout for that and fix it where you see it.

Criteria 4: Implementation Adheres to DRY Principles

  • _Score Level: 4/4
  • _Comment(s): You reused components properly.

Overall Score: 16/16

You did a great job on your project. Nice job using requests in your Spotify.js file and having the patience to figure out the hard parts. In your component files you did a great job using off you understand how to use React. Great job updating state, binding methods, using props, rendering children and more. Lastly, great job getting your project hosted with Surge. All in all, you showed that you put a lot of effort in this project and you did a really good job.

Spotify Login

the first time a user searches for a song, album, or artist, Spotify will ask them to log in or set up a new account. You will need to follow the steps in the Spotify Developer Guide to register your application.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.