masterskriptor / dotnetcore2-framework Goto Github PK

The Contact Controller required the ApplicationUser Model in EXCSLA.Models. The user should be able to use any class that implements IdentityUser in the event they have a custom user class they have implemented.

Add a folder for combining the nuget packages into a single package called EXCSLA.DotNetCore2.All so users do not have to add package references for each package they use.

The contact controller has routes hard coded into the base controller. The contact controller base should have all virtual methods so that they can be overridden.

This framework seriously needs some documentation if you want anyone to use it....

The IDataService needs to be updated to include the methods added to DataService for adding children to objects.

The Contact Controller base class requires the UserManager and the Configuration Manager to initialize. Look into using options in the startup.cs to make the controller easier to use and initialization cleaner.

FileUploadService needs to have an argument for relative paths to upload to. Currently it defaults to "products/images." Also allow for configuration to set a default relative path in the event a path is not supplied in the call.

The Reply method of the ContactControllerBase uses IsNullOrEmpty method to test for configuration key. Instead check the Configurations' keys to see if it exists.