GithubHelp home page GithubHelp logo

material-foundation / cocoapods-catalog-by-convention Goto Github PK

View Code? Open in Web Editor NEW
19.0 11.0 13.0 475 KB

Build a Catalog application using conventions and CocoaPods

Home Page: https://material-foundation.github.io/cocoapods-catalog-by-convention/

License: Apache License 2.0

Ruby 5.69% Swift 4.92% Objective-C 85.45% Shell 0.63% Starlark 3.31%

cocoapods-catalog-by-convention's People

Contributors

ajsecord avatar bryanoltman avatar djjliang avatar ianegordon avatar jverkoey avatar randallli avatar yarneo avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

cocoapods-catalog-by-convention's Issues

[Crash] CBCClassesRespondingToSelector crashes on 10.3 when using Reveal

Overview

On MDCCatalog, with 10.3 simulator (Xocde 8.3 Beta 1-5), running Reveal via breakpoint injection, it will crash when asking WebKit classes if they respond to selector (during the navigation tree creation.)

if ([aClass respondsToSelector:selector])

Workaround:

Ignore classes starting with "WK". Not a true solution but will work until a solution.

NSArray<Class> *CBCClassesRespondingToSelector(NSArray<Class> *classes, SEL selector) {
  NSMutableArray<Class> *filteredClasses = [NSMutableArray array];

  for (Class aClass in classes) {
    NSString *catch = NSStringFromClass(aClass);
    if ([catch containsString:@"WK"]) {
      continue;
    }

    if ([aClass respondsToSelector:selector]) {
      [filteredClasses addObject:aClass];
    }
  }
  return filteredClasses;
}

Formalize a generalized pattern for returning example metadata

Currently, to add new metadata to examples we need to add new APIs to the library and cut a release, e.g. #24.

If we had a more generalized mechanism for defining example metadata then we would be able to move all metadata definitions into the downstream apps. This would mean fewer releases of catalog by convention.

For example, one possible solution is to define an + catalogMetadata API that returns a dictionary. The app could then define keys it expects examples to implement.

Profile the Catalog By Convention on-device runtime cost of initializing the navigation tree and explore improvements

There have been reports that app startup time is noticeably degraded in complex apps that make use of the catalog by convention. It's decently likely that our enumeration of the runtime is playing a part in this.

  • Profile the Material Components for iOS catalog app on a device.
  • If costly code is discovered, send a PR to address the cost (likely be some mechanism of caching or alternative runtime APIs).

Consider renaming the repo to something more descriptive

The "convention" aspect of this library is a side effect of the included tech. What this library is, at its simplest, is a runtime lookup of view controllers that respond to specific selectors and the construction of a navigable view controller hierarchy.

Will use this thread to source better names.

[VoiceOver] Collection cells should be an accessibility element

The CBC cells (main list/tiles) are not accessibility elements. VoiceOver users can only tap on the labels within each cell. Instead, the entire cell should be the accessibility element and should provide the values/labels/traits of the label and act as a button.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.