mathiasgilson / musiccontrollerchromeextension Goto Github PK

Hey,

it would be great if it would be possible to disable the hotkeys for specific sites or set a priority for sites.
For example, do I want to control Spotify, Deezer... while using Twitch but pausing it will end up pausing twitch.

Plugin does not work. Installed for MS Edge 86.0.622.56 running on a Mid-2015 MBPr running macOS Catalina 10.15.7.

Add a special setting, or enable the "Switch Tracks" feature by default, only on tabs that contain &list in location.href [For YouTube]

On Windows 10 with Chrome Beta 81, in case there are a few YouTube tabs with videos open, the extension does resume playback on the first tab and not the last played one.

When using this extension, information about what is playing (title, artist, image) contained in window.navigator.mediaSession.metadata is not displaying.

The extension works on a Brave browser tab, but when youtube is opened as PWA, then it doesn't work with extension, but before extension play/pause worked.

Extension does not work when Chrome is minimized or in background.

I'm using desktop version of youtube music on my mac and hotkeys are not working unless you are using hotkeys in main chrome window. Is there any way to fix this? Thank you

This would make this tool perfect for my use case as I use it while taking notes on YouTube

Good morning, I've just checked that extension was not working on Deezer; and just took a look at the code, and it is happening because the selector for getting buttons is using aria attribute, so it is not consistent between languages (if you have the browser in a language that is not English, aria-label will not be 'Next' and it will not work, for instance in Spanish it is 'Siguiente'):

"www.deezer.com": {
  buttonBased: true,
  next: `'.svg-icon-group-btn[aria-label="Next"]'`,
  prev: `'.svg-icon-group-btn[aria-label="Back"]'`,
  playPause: `'.svg-icon-group-btn[aria-label="Pause"], .svg-icon-group-btn[aria-label="Play"]'`,
}

As this selectors are being used directly to apply the click event; and there is no a 'parent selector' in JS, I can't get a clean direct solution to this because the 'back', 'play', 'next' classes are directly in the child svg item; and it is not clickable directly through click() method.
In a dirty way, maybe it could be fixed using this selectors, but I don't know if there could be any side effect (that empty svg-icon-group-item list items that deezer put there are really suspicious, but it seems that they are using it just for margin):

"www.deezer.com": {
  buttonBased: true,
  next: `'.svg-icon-group-item:nth-child(5) .svg-icon-group-btn'`,
  prev: `'.svg-icon-group-item:nth-child(1) .svg-icon-group-btn'`,
  playPause: `'.svg-icon-group-item:nth-child(3) .svg-icon-group-btn'`,
}

It should work with current Deezer HTML structure, and doesn't need to modify the JS working with diferent flows; working just like it is doing till now, but in every lang.

Thanks for your work! If I can help with something, let me know!

The plugin remembers the last video you click on, instead of the one you currently have on screen, i would be a nice feature.