mathomp4 / flap

Fortran command Line Arguments Parser for poor people

Greetings! 👋

I am a software developer who works for SSAI at the GMAO (Global Modeling and Assimilation Office) at NASA Goddard Space Flight Center.

I mostly work on the GEOS ESM (Goddard Earth Observing System Earth Science Model which is now managed here on GitHub. The code is at the GEOS-ESM organization. What once was a large monolithic code base is now separated into many smaller repositories managed by mepo, a GMAO-built multi-repository tool.

I mainly code in Fortran and have tried things like Code Golf where I am middle of the pack at the moment. 😄

flap's Issues

FLAP CMake is kind of broken

This is mainly a query/call for help from @LiamBindle (which is why I've added him as a collaborator here).

The issue is that find_package(FLAP) isn't quite working. With my latest edits, the geos branch does okay with includes, but it fails on the link step. The problem is that the library the FLAPConfig.cmake file refers to is the one in the build directory and not in the installation directory. So once you delete your build directory, things using FLAP fail.

As an example, I created a repo:
https://github.com/mathomp4/FLAPBug

Here, you first build FLAP (geos branch) and notice what is in the FLAPConfig.cmake that is made:

# Import target "FLAP::FLAP" for configuration "Release"
set_property(TARGET FLAP::FLAP APPEND PROPERTY IMPORTED_CONFIGURATIONS RELEASE)
set_target_properties(FLAP::FLAP PROPERTIES
  IMPORTED_LINK_INTERFACE_LANGUAGES_RELEASE "Fortran"
  IMPORTED_LOCATION_RELEASE "/home/mathomp4/FLAPCMakeBug/FLAP/build/src/lib/libFLAP.a"
  )

That last one is pointing to the build, not the installed libFLAP.a.

Now, I tried various things to fix this and failed. In fact, I even tried a complete overhaul of FLAP's cmake system (see branch flap-like-face). On the plus side, in that one you could do:

target_link_libraries(blah FLAP)

instead of:

target_link_libraries(FLAP::FLAP)

which seems "cleaner" but with the downside that nothing worked. At least in the geos branch the include bits work.

FLAP incorrectly assumes PENF and FACE are in lib

Building off of the fixes of @LiamBindle in #1, there seems to be an issue. Building with a standard cmake, all the libraries for FLAP, PENF, and FACE are installed into ${CMAKE_INSTALL_PREFIX}/lib64. But, the CMakeLists.txt has:

FLAP/CMakeLists.txt

Line 124 in 8c24022

SET(PENF_LIBRARY ${CMAKE_INSTALL_PREFIX}/lib/libPENF.a)

FLAP/CMakeLists.txt

Line 139 in 8c24022

SET(FACE_LIBRARY ${CMAKE_INSTALL_PREFIX}/lib/libFACE.a)

I think I have a more generic solution for this incoming where one can do:

cmake ... -DCMAKE_INSTALL_PREFIX=/path -DCMAKE_INSTALL_LIBDIR=yaya

and it will correctly install the libraries all in /path/yaya.