matrix-org / dendron Goto Github PK

On a development synapse:

curl -XPUT -d '{}' "http://localhost:8008/_matrix/client/r0/rooms/%21cBrPbzWazCtlkMNQSF:localhost/state/m.room.bridging/irc%3A%2F%2Firc.test.com%2F%23tsomething?access_token=MDA....H1Cg"

HTTP/1.1 200 OK
Content-Length: 53
Access-Control-Allow-Headers: Origin, X-Requested-With, Content-Type, Accept
Server: Synapse/0.18.3 (b=develop,9355a5c)
Date: Mon, 21 Nov 2016 11:43:41 GMT
Access-Control-Allow-Origin: *
Access-Control-Allow-Methods: GET, POST, PUT, DELETE, OPTIONS
Content-Type: application/json
{
    "event_id": "$14797283221088yNiKx:localhost"
}

Same request on matrix.org:

curl -XPUT -D - -d '{}' "https://matrix.org/_matrix/client/r0/rooms/%21wAtthICZcUpPDfXPJp:matrix.org/state/m.room.bridging/irc%3A%2F%2Firc.test.com%2F%23tsomething?access_token=MDA...x"

HTTP/1.1 301 Moved Permanently
Location: /_matrix/client/r0/rooms/%21wAtthICZcUpPDfXPJp:matrix.org/state/m.room.bridging/irc:/irc.test.com/%23tsomething?access_token=MDA...x
Date: Mon, 21 Nov 2016 11:42:58 GMT
Content-Length: 0
Content-Type: text/plain; charset=utf-8

Note the state_key in the Location is irc:/ and not irc://. Knowing Go, this is probably a Path vs RawPath bug.

I'm trying to figure out where to start on implementing things over here.

The biggest question I have is just whether the plan is for dendron and synapse to share the same postgres database and over time have more functionality moved into dendron (I assume yes, but confirmation before I get going on that would be nice!)

The more general question though is whether docs about the overall expected design or development of this project exist anywhere.

Do they?

Currently, there's the terminate channel used to signal the server should shutdown.

Due to the defer cleanups for the processes spawned, those are nicely cleaned up on terminate, but the version handler is not given such an opportunity. Presumably, this will also apply to other handlers and components in the future.

I think we should have good hygiene about using a context.Context from the beginning, and in addition should replace the defer cleanup with a ctx as well.

I'm happy to make this change if it makes sense to have.