matt448 / nagios-checks Goto Github PK

check_s3_file_age.py:180-181 - The error message is "CRITICAL - ...", but the exit code is 3 (Unknown). Think it should be exit code 2 (Critical).

I'm checking file age on a bucket containing over 24000 items, and it's really slow. Would be useful to be able to supply a prefix or filter in order to narrow down the results that S3 returns, before the checks are performed on --bucketfolder.

The script does not ignore the bucket folder itself, so if the bucket is quite new then the check will pass.

For example, create a bucket to hold weekly backups. The bucket is initially empty, but has an age of zero. Checking --minfileage 168 (i.e. 7 x 24 hours) will return OK for the first 168 hours, then fail (assuming you haven't written anything).

Note that as a workaround you can use wildcards, e.g. --bucketfolder 'hourly/.+', i.e. insist on at least one character after the slash.