mattermost / matterbuild Goto Github PK

I happened to cut a plugin release by issuing a command in a DM -- expecting the interaction to be ephemeral -- but got a post from matterbuild in that DM with the details.

Should we consider using a bot to communicate with the executor instead?

Integrate golangci-lint into this repository. https://github.com/mattermost/mattermost-plugin-starter-template/blob/master/.golangci.yml should be used as a starting point for the configuration. https://circleci.com/orbs/registry/orb/gotest/tools is a good circleci orb on install golangci-lint.

make check-style should be changed to:

## Checks code style.
.PHONY: check-style
check-style: golangci-lint
	@echo Checking for style guide compliance

## Run golangci-lint on codebase.
.PHONY: golangci-lint
golangci-lint:
	@if ! [ -x "$$(command -v golangci-lint)" ]; then \
		echo "golangci-lint is not installed. Please see https://github.com/golangci/golangci-lint#install for installation instructions."; \
		exit 1; \
	fi; \


	@echo Running golangci-lint
	golangci-lint run ./...

The success post should be in the same thread as the announcement post.

There is currently a vendor directory which, as discussed at the dev meeting, is only strictly needed for the mattermost-server. Hence, I propose to drop it and make PR reviews like #17 easier.

cc @agnivade @ali-farooq0 @metanerd