matthewp / haunted-starter-app Goto Github PK
View Code? Open in Web Editor NEWCreated with CodeSandbox
Home Page: https://codesandbox.io/s/github/matthewp/haunted-starter-app
haunted-starter-app's People
Contributors
Stargazers
Watchers
haunted-starter-app's Issues
Demo Broken?
https://codesandbox.io/s/github/matthewp/haunted-starter-app doesn't seem to work anymore. This library looks super cool, I would love to be able to play around with it.
edit: It must be something with codesandbox because cloning the repo locally and via glitch works fine. Maybe consider adding a link to remix with glitch unless it can start working in codesandbox...
Dispatch should be done inside of a useEffect
Currently, dispatch is called within FullName meaning that on any rerender dispatch will be called. This works fine for now because the only rerendering that happens is when first and last change, however, I would consider this an anti-pattern. If you add any code that causes FullName to rerender you're unnecessarily dispatching and causing App to rerender as well.
dispatch should be inside of a call to useEffect with the dependencies as first and last
It also seems unnecessary to move dispatch out of the component seeing as the logic inside of dispatch is tightly coupled to FullName's specific use case.
index.html is missing a bunch of stuff
List of things missing from index.html file:
- Closing tag for
<html> <head>tags<body>tags- Responsive
<meta>tag
The file also needs to be formatted as it has no indentation whatsoever right now.
Fix accessibility of form inputs
In the example, there are a few accessibility issues with the form inputs:
- Related form inputs should be wrapped in a
<fieldset>with a<legend>. - The
forattributes on the<label>s need to have correspondingidattributes on their respective<input>elements.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.