GithubHelp home page GithubHelp logo

Comments (4)

masahino avatar masahino commented on July 4, 2024

I use latest version of mruby(6b2f08d).

from mruby-onig-regexp.

mattn avatar mattn commented on July 4, 2024

Hmm, can't repro

image

from mruby-onig-regexp.

masahino avatar masahino commented on July 4, 2024

On my environment(tried on Mac and Ubuntu), mrb_str_new is called with len = -3 at str_substr.

return mrb_str_new(mrb, RSTRING_PTR(str) + beg, len);

This is because reg->end[0] = 4 in match_data_post_match, but I am not sure if this is the correct behavior.

return str_substr(mrb, str, reg->end[0], RSTRING_LEN(str) - reg->end[0]);

How about checking len as follows?

masahino@25b1522

from mruby-onig-regexp.

mattn avatar mattn commented on July 4, 2024

Looks good. Could you please send me PR?

from mruby-onig-regexp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.