Abort on UTF-8 split with empty src about mruby-onig-regexp

[mattn]

I don't repro.

[ksss]

Seems not resolved.

$ mruby -e 'p "あいうえお".split(//)'
Assertion failed: (((((const mrb_value*)((struct RArray*)((result).value.p))->ptr)[i - 1]).tt == MRB_TT_STRING)), function string_split, file /Users/ksss/src/github.com/ksss/mruby-onig-regexp/src/mruby_onig_regexp.c, line 863.
[1]    57589 abort      ./build/host/bin/mruby -e 'p "あいうえお".split(//)'

[mattn]

Hmm, I don't repro.

["\343\201\202", "\343\201\204", "\343\201\206", "\343\201\210", "\343\201\212"]

[mattn]

And line 863 is not operatable code.

  if (limit == 0) { // remove empty trailing elements

[ksss]

Sorry, I tried to rebuild it.

$ uname -v
Darwin Kernel Version 16.4.0: Thu Dec 22 22:53:21 PST 2016; root:xnu-3789.41.3~3/RELEASE_X86_64

$ clang -v
Apple LLVM version 8.0.0 (clang-800.0.42.1)
Target: x86_64-apple-darwin16.4.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

$ pwd
/Users/ksss/src/github.com/ksss/mruby

$ git rev-parse HEAD
3703aed7ab7c056ef7a58fd8d25b84b59f715dad

$ pkg-config --list-all | grep onig

$ cat build_config.rb
MRuby::Build.new do |conf|
  toolchain :gcc
  enable_debug
  conf.gembox 'default'
  conf.gem mgem: "mruby-onig-regexp"
end

$ git diff include
diff --git a/include/mrbconf.h b/include/mrbconf.h
index 4796919c..1eecb3e6 100644
--- a/include/mrbconf.h
+++ b/include/mrbconf.h
@@ -44,7 +44,7 @@
 //#define MRB_WORD_BOXING

 /* string class to handle UTF-8 encoding */
-//#define MRB_UTF8_STRING
+#define MRB_UTF8_STRING

 /* argv max size in mrb_funcall */
 //#define MRB_FUNCALL_ARGC_MAX 16

$ rm -fr build && rake clean && rake
# ...snip...

$ ./build/host/bin/mruby -e 'p "あいうえお".split(//)'
Assertion failed: (((((const mrb_value*)((struct RArray*)((result).value.p))->ptr)[i - 1]).tt == MRB_TT_STRING)), function string_split, file /Users/ksss/src/github.com/ksss/mruby-onig-regexp/src/mruby_onig_regexp.c, line 866.
[2]    66618 abort      ./build/host/bin/mruby -e 'p "あいうえお".split(//)'

$ sed -n '866p' /Users/ksss/src/github.com/ksss/mruby-onig-regexp/src/mruby_onig_regexp.c
      mrb_assert(mrb_string_p(RARRAY_PTR(result)[i - 1]));

$ cd build/mrbgems/mruby-onig-regexp; git rev-parse HEAD; cd ../../../
17e8663da6d597f85c75aeda2737971f2c756fa3

MRB_UTF8_STRING is an important point.

[mattn]

should be fixed.

[ksss]

I was able to confirm the fix.
Thanks!