Comments (6)
Yep I strongly believe since they are dependencies, cargo will load them all no matter the feature flags, but best to confirm it with a test.
from tower-sessions.
Unfortunately I didn't have the time to perform the test.
The easiest way to do it would be to switch the version of dependencies in a way that makes the subdependencies incompatible with one another.
The earliest I can try this test is in January though.
from tower-sessions.
Since we're publishing separate crates currently, does this mean that we should not re-export those crates via feature flags from the main crate? (I think this will lead to the issue you're describing.)
from tower-sessions.
That being the case, I don't think it'll be too difficult to move toward removing the feature flags since we're done the work of physically separating stores into their own crates.
It's maybe also worth taking a second look at sqlx
and how they approach this: I think they're able to get away with this because there's no problem with all SQL engines being enabled at the same time.
from tower-sessions.
@czocher were you able to determine that the feature flags indeed cause the interaction that you mentioned here? If so, should we proceed by removing the feature flags in tower-sessions
and instead have applications require stores as separate deps?
from tower-sessions.
I think from a UX perspective, it might be cleaner to require session stores as dependencies anyway, omitting the feature flags altogether.
One downside is that testing these stores might become more cumbersome. (Or perhaps we require the same set of stores we currently have as dependencies of the integration test suite.)
from tower-sessions.
Related Issues (20)
- 2 Errors when installing with postgres HOT 11
- i do not see a postgres table although session works HOT 1
- cannot infer type of the type parameter `T` declared on the struct `HandleErrorLayer` HOT 2
- function or associated item not found in 'Session' HOT 2
- Add support for Postgres store with tokio-postgres along with bb8-postgres. Implementation attached.
- Facilitate custom `SessionStore` implementation testing HOT 12
- Use `core::time::Duration` instead of `time::Duration`
- Redis example needs pool not a client
- Still waiting on your answer regarding #59 (Diesel store implementation) HOT 3
- with_expiry(Expiry::OnSessionEnd) does not seem to work
- Does .flush() work correctly when a cookie domain is set?
- version 0.10.3 broke SemVer guarantees HOT 3
- Breaking change in v0.10.4 HOT 4
- Inserting forces a sesssion read which could cause the insert to error HOT 1
- set_expiry() does not work HOT 5
- Max-Age of Cookie not updates on set_expiry() HOT 3
- Session Ids can collide
- Version 0.12.0 not compatible with redis-store 0.11.0 HOT 1
- Calling `session.save()` correctly creates new sessions but the cookie is not set.
- Change tracing levels for instrumentation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tower-sessions.