GithubHelp home page GithubHelp logo

Comments (6)

czocher avatar czocher commented on May 31, 2024 1

Yep I strongly believe since they are dependencies, cargo will load them all no matter the feature flags, but best to confirm it with a test.

from tower-sessions.

czocher avatar czocher commented on May 31, 2024 1

Unfortunately I didn't have the time to perform the test.
The easiest way to do it would be to switch the version of dependencies in a way that makes the subdependencies incompatible with one another.
The earliest I can try this test is in January though.

from tower-sessions.

maxcountryman avatar maxcountryman commented on May 31, 2024

Since we're publishing separate crates currently, does this mean that we should not re-export those crates via feature flags from the main crate? (I think this will lead to the issue you're describing.)

from tower-sessions.

maxcountryman avatar maxcountryman commented on May 31, 2024

That being the case, I don't think it'll be too difficult to move toward removing the feature flags since we're done the work of physically separating stores into their own crates.

It's maybe also worth taking a second look at sqlx and how they approach this: I think they're able to get away with this because there's no problem with all SQL engines being enabled at the same time.

from tower-sessions.

maxcountryman avatar maxcountryman commented on May 31, 2024

@czocher were you able to determine that the feature flags indeed cause the interaction that you mentioned here? If so, should we proceed by removing the feature flags in tower-sessions and instead have applications require stores as separate deps?

from tower-sessions.

maxcountryman avatar maxcountryman commented on May 31, 2024

I think from a UX perspective, it might be cleaner to require session stores as dependencies anyway, omitting the feature flags altogether.

One downside is that testing these stores might become more cumbersome. (Or perhaps we require the same set of stores we currently have as dependencies of the integration test suite.)

from tower-sessions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.