maxiomtech / dnn-module-template Goto Github PK

This solution would not build upon initial clean setup for us. We tried multiple times, but ultimately had to resort to running the following in the Package Manager Console about 30+ times (honestly stopped counting) to get all the /Scripts files downloaded.

Update-Package -reinstall

After this, the project was able to build. So far, so good! We are going to try and build our first module using this template and see how it goes. Thanks for creating this and making it available!

Hi there, I pulled down this module template to give it shot. First impression was great. Instructions were very helpful.

But there are a few things I noticed which didn't work for me (read to the end for solution).

1. After executing Setup Template.ps1 script I opened the project by double clicking the NewModule.sln file. The very first error message greeted me said that Website located at localhost:{cant_remember_the_port_number} cannot be found.
2. After building the project in Release mode the Nuget did not populate Script/ or Content/ folders. So, I had to do that manually.
3. Upon successful installation the example didn't work for me.

3a. Loader.ascx is referencing /Client/app.js which doesn't exist.
However, there is a file named app.ts but when I switch definition to /Client/app.ts I get Uncaught SyntaxError: Unexpected identifier on line 2 module LinkWise { of app.ts file.

3b. {{vm.hello}} is not replaced by the result from the WebApi GetTestEntity().

3c. Api.ts getData() ether doesn't get data from GetTestEntity or fails after it get the data. Therefore no result is returned back to the MainCtl.ts. Therefore <div ng-controller="MainCtl as vm"> has no value to put sub into {{vm.hello}}.

3d. Typing anything into <input type="text" data-ng-enter="vm.helloWorld()" /> of Main.ascx and hitting carriage return key results in me getting redirected to DNN home page. But I am expecting slightly different behaviour to happen when helloWorld() is executed

public helloWorld() {
    this.$log.info('I accept your greeting');
}

Now in saying all the above this module template was the first time I came across TypeScript. And that was part of the problem. After installing TypeScript 1.4 for my VS 2013 app.js appeared where expected, service was getting data from GetTestEntity(). Basically module template started to work as expected.

The only two things that concern me at this point are 2 and 3d.

But I have not yet tired another clean install to see if Scripts/ and Content/ folders would populate with files appropriately.

PS: As I said before the instruction were great. But perhaps if something like TypeScript is among required tools to enable the use of this template would have helped to kick start the process.

PSS: I was testing this on clean DNN 7.3.3 install.

PSSS: Very nice module template hands down. Now I just need to learn how to make proper use of it :p

Any chance you could create a Side Waffle project template for this?

NuGet installs everything on first build and puts all of rx.js ts files into the /Scripts folder (instead of Scripts/Typings) creating duplicate errors in the build. To get around the issue I just deleted all references to Scripts\typings\rx.js* in ModuleName.csproj and just let NuGet insert new TypeScriptCompile entries for rx.js when it installs.

That seems to fix most of the issues. I was also seeing this issue DefinitelyTyped/DefinitelyTyped#3081 and updated my rx.js versions to get their fix. I'd be happy to put together a pull request, but I figured I should let you know first. I'm not 100% sure I fixed this the right way.

Also, thanks for putting this template on GitHub, it is a huge help!