maxuss / macrocosm

A hypixel-skyblock like plugin for Paper

macrocosm's Issues

Item API Enhancement

Currently the MacrocosmItem API is very clumsy and it wasn't really updated since the start. Because of that, adding hardcoded items is not really easy.

Complex data serialization

Currently a lot of internal data is stored as JSON strings inside a database. This can be theoretically improved by saving data in binary and then encoding it with base64.

Possible improvements:

1. Less size taken in database
2. Less time taken on serialization/deserialization

Possible disadvantages:

1. (possibly) Higher RAM usage and memory footprint due to use of bytebuffers

Plugin doesn't start

After the new fixes, Macrocosm doesn't start. Here's the log: https://pastes.dev/e9UiBDfmDu

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• Update dependency gradle to v8.2

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update dependency LibsDisguises:LibsDisguises to v10.0.37
• Update dependency io.ktor:ktor-client-core to v2.3.2
• Update dependency io.ktor:ktor-client-java to v2.3.2
• Update dependency net.dv8tion:JDA to v5.0.0-beta.12
• Update plugin org.jetbrains.dokka to v1.8.20
• Update dependency io.ktor:ktor-server-core-jvm to v2.3.2
• Update dependency io.ktor:ktor-server-default-headers-jvm to v2.3.2
• Update dependency io.ktor:ktor-server-netty-jvm to v2.3.2
• Update dependency io.ktor:ktor-server-status-pages-jvm to v2.3.2
• Update dependency net.axay:kspigot to v1.20.1
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

github-actions

.github/workflows/docs.yml

• actions/checkout v3
• actions/setup-java v3
• actions/deploy-pages v2

gradle

gradle.properties

settings.gradle.kts

build.gradle.kts

• org.jetbrains.kotlin.jvm 1.8.22
• xyz.jpenilla.run-paper 2.1.0
• io.papermc.paperweight.userdev 1.5.5
• org.hidetake.swagger.generator 2.19.2
• org.jetbrains.dokka 1.8.10
• net.axay:kspigot 1.19.2
• com.comphenix.protocol:ProtocolLib 5.0.0
• LibsDisguises:LibsDisguises 10.0.35
• io.ktor:ktor-client-core 2.3.0
• io.ktor:ktor-client-java 2.3.0
• io.ktor:ktor-server-core-jvm 2.2.4
• io.ktor:ktor-server-netty-jvm 2.2.4
• io.ktor:ktor-server-default-headers-jvm 2.2.4
• io.ktor:ktor-server-status-pages-jvm 2.2.4
• net.dv8tion:JDA 5.0.0-beta.10
• club.minnced:discord-webhooks 0.8.2
• org.litote.kmongo:kmongo 4.9.0
• io.prometheus:simpleclient 0.16.0
• io.prometheus:simpleclient_httpserver 0.16.0

gradle-wrapper

gradle/wrapper/gradle-wrapper.properties

• gradle 8.1.1

---

• Check this box to trigger a request for Renovate to run again on this repository

Unify registries

Currently there are still some objects that store data internally, e.g. the BuffRegistry or the Cosmetics enum. This is not really great for extending purposes, so they should be converted to normal registries (space.maxus.registry.Registry) instead

Registry Pointers

Currently some classes store registry elements inside itself (e.g. MacrocosmItem which contains MacrocosmAbility). Even though JVM holds these objects as references, they still take a lot of space during serialization, and due to the fact they are interfaces, sometimes it is hard/impossible to deserialize them without some workarounds. RegistryPointer are supposed to solve that issue. They will hold only ID of element, and ID of registry that the element belongs to.

Some problems

I'll list the errors/bugs I have found so far.

ERRORS

• PlayerInteractEvent: https://pastes.dev/HvKvJKMbtn
  This error occurs when you try to interact with any item, whether added by Macrocosm or not. Examples:

  1. When killing a monster
  2. By right clicking
  3. When clicking on a block

• PlayerCalculateStatEvent: https://pastes.dev/slfE68eUFJ
  Occurs when you equip an item or armor that increases your stats.

• Resourcepack generation: https://pastes.dev/0n4nKxBlmn
  The resourcepack is not generated correctly at server startup, it's not applied to players when they enter the server.

BUGS

• Items Menu (/items)
  When the next page button is pressed, the page changes four times and it should be only once.