mayermart / nhplugin Goto Github PK

To reproduce:

1. Create a mapping to a boolean property.
2. Set the type to YesNo (a char(1) column with Y for true and N for false).
3. Notice the red squiggle under type="YesNo"
4. Compile

The mapping compiles and creates the schema just fine, but nhplugin doesn't
recognize YesNo as a valid type. I get the same issue with TrueFalse, as well.

http://www.hibernate.org/hib_docs/nhibernate/html/mapping.html#mapping-types-bas
ictypes

What steps will reproduce the problem?
1. Install Resharper 4.1
2. Run copy-plugin.cmd
3. Files are not copied because directory is hard coded

Patched file to use directory with 4.1
1. Launch VS.Net
2. Open any .hbm.xml file

The attached exception occurs.

Version: 0.0.9.2 of NH Plugin

I have a value type named DateTimeRange which can be found in the 
Contoso.Common namespace and when I type the following in the NHibernate 
mapping file:

<component class="Contoso

I get an unhandled exception from the moment I hit the . key. The expected 
behaviour is to see the IntelliSense dialog instead I get the following 
exception:

http://www.jetbrains.net/jira/browse/RSRP-72750

Hi every type in the mapping is being remarked as an error.
Is this a known problem or an environmental problem?

BTW. Great plugin.

Thanks.

Gustavo.

What steps will reproduce the problem?
1. If assembly name in the project properties does not match project name
pluging highlights it as an error saying "Assembly name should be a <VS
project name>. Tried to debug it got to
MappingFileAnalysisElementProcessor.cs HighlightUndefinedType method at
line 354 using module name instead of assembly name.

<property name="XmlData" type="StringClob">
            <column name="XmlData" length="1073741823" sql-type="ntext"
not-null="true"/>
        </property>

Error: 'Type StringClob could not be resolved'
Plugin version 0.0.9.4 @ R$ 4.1 @ VS 9.0 SP1
NHibernate 1.0.4.
StringClobType is defined in namespace NHibernate.Type

Hello, I think you might include the R# assemblies in the repository
because not all installations put them in the same place, and VS won't be
able to resolve the references. I think you are allowed to redistribute
them, others are doing it:
http://code.google.com/p/mbunit-resharper/source/browse/#svn/trunk/PlugIn/Extern
alAssemblies/ReSharper4.

I configured the NHPlugin for vs4.1 and every time i try to enter to an XML
mapping i get Resharper expection with a MethodMissingException.

Removing the plugin stopped the exception.

What steps will reproduce the problem?
1. Create an IUserType class to implement a custom type. For example:
http://www.lostechies.com/blogs/rhouston/archive/2008/03/23/mapping-
strings-to-booleans-using-nhibernate-s-iusertype.aspx
2. Add the user type to your mapping:
<property name="Descr" type="Framework.LegacyStringUserType, Framework"/>
3. Add the actual type to your class
class Product
{
 public string Descr { get;set;}
}

4. It will show as an error "class name LegacyStringUserType should be 
string or a descendant for getter property"

What is the expected output? What do you see instead?
No Error

What version of the product are you using? On what operating system?
0.0.9.4 / Resharper 4.1

Please provide any additional information below.
Thanks for the awesome plugin...

Is this project still alive?
If not, please could you mark is as dead so that we can know... 
I understand that this it's not a due to update or maintain and Open Source 
Project, but maybe an update on the future would be nice.

Many thanks for your comprehension.


Best regards,

Lorenzo
Resharper 5.x

What steps will reproduce the problem?
1. Entity
    public class BaseEntity {

        int _id;

        public int Id {
            get { return _id; }
        }
    }
    public class DerivedEntity : BaseEntity {

        public string AnsiField { get; set; }

    }
2. Map
  <class name="NHibernatePlugin.Tests.TestMiei.DerivedEntity,
NHibernatePlugin.Tests" table="Example" >

    <id name="Id" access="nosetter.camelcase-underscore" column="ID"
type="Int32" unsaved-value="0">
      <generator class="native" />
    </id>

    <property name="AnsiField" column="Name" type="AnsiString"
access="property" />

  </class>


What is the expected output? What do you see instead?
- name="Id" is underlined as an error: getter for property Id not found in
class DerivedEntity
- type="AnsiString" is underlined as an error: Type AnsiString could not be
resolved.


What version of the product are you using? On what operating system?
Revision 12 from repository

Please provide any additional information below.
Using resharper 4 and vs2008 sp1

when doing

<component name="compname">
  <prop...
  <prop...
</component>

every prop is accessible and navigate to the right place (class compname) 
but there is no navigation from compname to the property in the class 
where it is composed...

What steps will reproduce the problem?
1. Using a Visual Studio 2008 project where the project name is different 
than the assembly name.

What is the expected output? What do you see instead?
The plugin marks the class-name as en error: "Assembly name 'Company.Model' 
should be marked 'Company.Model.X'.

What version of the product are you using?
0.0.9.3

As a developer I would like to be able to reformat the markup in the
NHibernate mapping file using the ReSharper shortcuts for reformatting code
because so that the NHibernate mapping files becomes more human readable if
the layout is messed up.

As a developer I want support for the usage of generic types in the
NHibernate mapping files.

See this example:
http://blogs.chayachronicles.com/sonofnun/archive/2006/10/04/5.aspx

With the current version of the Nhibernate plugin for ReSharper you will
get the following error:

Type 'Cei.eMerge.Common.Range`1[System.DateTime], Cei.eMerge.Common' could
not be resolved.

What steps will reproduce the problem?
1. define
    public interface IEntity<T>
    {
        T ID { get; }
    }

    abstract public class BaseEntity<T> : IEntity<T>
    {
        private T _id;
        public virtual T ID
        {
            get { return _id; }
            protected set { _id = value; }
        }
    }

    public abstract class VersionedBaseEntity<T> : BaseEntity<T>
    {
        private int _version;
        public virtual int Version
        {
            get { return _version; }
        }
    }

    public abstract class BaseAPPEntity : VersionedBaseEntity<Guid>
    {
    }

    public partial class MyEntity: BaseAPPEntity 
    {
        public virtual string Name { get; set; }

        public MyEntity()
        {
        }
    }

Mapping:
<id name="ID" column="ID" type="Guid" access="field.lowercase-underscore">
   <generator class="guid.comb"/>
</id>


What is the expected output? What do you see instead?
Expected -> no warning
I see: Class name 'Guid' should be 'T' or a descendant for field '_id'

What version of the product are you using? On what operating system?
0.0.9.4

Please provide any additional information below.
Just downloaded latest trunk (version 20) and debugged. The problem is in
Analysis\MappingFile\MappingFileAnalysisElementProcessor.cs: 446.
R# says that fieldtype is T instead of Guid. I don't know how this works
(first time i see r# api), just tried a quickwatch to see if there are some
other property with 'Guid' type but i haven't found. So i dont' know if the
problem is in r# or in your code, the standard r# analysis worked fine.

This is a feature request.

As a developer I want to rename the persistant class from within the 
NHibernate mapping file so that I don't need to manually open the 
persistant class in the editor and then rename it from there.

Eg:

I have an entity SalesModel and the following line in the NHibernate 
mapping file:

<class name="SalesModel" table="MP_MD_SalesModel" batch-size="100">

I then want to be able to rename SalesModel using ReSharpers Rename 
Refactoring.

I have the following in the NHibernate mapping file:

<class name="SalesModel" table="MP_MD_SalesModel" batch-size="100">

When I use the Rename Refactoring this will result in having the fully
qualified typename in the NHibernate mapping file as following:

<class name="Contoso.Core.SalesModelRenamed, Contoso.Core"
table="MP_MD_SalesModel" batch-size="100">

It is not a big issue but still this is unexpected behaviour.

I defined in a class the following
<class name="LoteServicio" table="LotesServicios" proxy="ILoteServicio">

The plugin does not check if ILoteServicio exists and does not navigate to
it...

I don't know how difficult it is, but it will be nice to have this check also.

Will be nice when this plugin will work with newer versions of Reshaper

If a property does not have a setter the tool rightly flags this as an 
error. But sometimes you do not want a public setter exposed, so in that 
case you can set access="nosetter.camelcase" etc, this should remove the 
error but it doesn't.

The message received is still "Setter for property X not found in class Y."

Cheers,

A ReSharper 5.0 version would be helpful.

This is a feature request.

As a developer I want to be able to navigate from within the NHibernate 
mapping file to referred types so I don't need to manually find the file.

It basically comes down to the fact that it should be possible to navigate 
to the type specified in the "class" attributes of the following elements:

<generator>
<one-to-many>
<composite-id>
<key-many-to-one>
<many-to-one>
<one-to-one>
<component>
<import>
<meta-value>
<definition>

It should also be possible to navigate to the types specified in 
the "type" attributes for the following elements:

<id>
<discriminator>
<property>
<key-property>
<version>

It should also be possible to navigate to the types specified in the "id-
type" and the "meta-type" attribute of the <any> element.

<property name="LastChangedTime" column="LastChangedTime" 
type="Timestamp"/>

This is a valid type according to the NHibernate docs but is flagged as an 
error. 

Thanks,

This is a feature request.

As a developer I want to able to navigate to the class from within the 
NHibernate mapping file so I don't have to manually search for the class 
to open it.

Eg:

Let's say I have a SalesModel entity in my project and that I have the 
following line in the NHibernate mapping file:

  <class name="SalesModel" table="MP_MD_SalesModel" batch-size="100">

I want to be able to right-click SalesModel and select "Go to Declaration" 
which then takes me to the class. ReSharper has also the option where you 
can navigate to types and members by holding <Ctrl>. This works for the 
<property> elements but not yet for <class>.