mayokunadeniyi / instant-weather Goto Github PK

I want to participate in your project。
Please provide the todo list.

It would be nice to have such option like this....
and user will be redirected to app listing on play store

Hi, @mayokunthefirst I have PR suggestion to add this pattern between Tapping destinations in a bottom navigation bar. In addition, I will provide a screen recording before and after the usage of this pattern inside the app. If it's okay, please assign me for this issue.

Hi,
I'm learning how mvvm structure works so I forked this repository and tested it.
Just one thing that I think it could be better is, the recyclerView in ForecastFragment doesn't show any items after I did the following steps:

• Show today's forecast list
• Scroll to the end
• Select another date from calendar

It's not a critical issue because the items shown again after I refreshed the list, but still wanted the filtered list to be displayed immediately after filtering.

I think the index of current position after scrolling went out of bound of the filtered list’s length might be the reason, but failed to fix it.
If you have any idea for how to optimize this please contact me.

Hey, I just cloned the latest project from the main branch but couldn't run it. As soon as the Gradle sync ends, the following error pops up. I tried many things but couldn't get it up and running.

Can you please help me with it?

ERROR MESSAGE: The Hilt Android Gradle plugin is applied but no com.google.dagger:hilt-android dependency was found.\

I am running it on MacBook M1

This project only allows for the use of °C (celcius) unit of temperature. A feature to allow users select their preferred unit either °C or °F would be way better.

• Implement feature to toggle between °C and °F

Version: 1.0
Steps to reproduce:

1. Install the app and open it, then click on bottom menu called Forecast
2. Now click on whatever day of the top weekly calendar.
3. The app closes itself.

Licence file not updated

class WeatherLocalDataSourceImpl
is thrown a null pointer exception

so returning an empty DBWeather if it's null fixing the issue

override suspend fun getWeather(): DBWeather? = withContext(ioDispatcher) {
if (weatherDao.getWeather() == null) {
return@withContext DBWeather(
cityId = 0,
cityName = "None",
wind = Wind(
speed = 0.0,
deg = 0
),
networkWeatherDescription = listOf(),
networkWeatherCondition = NetworkWeatherCondition(
temp = 0.0,
pressure = 0.0,
humidity = 0.0
)
)
} else {
return@withContext weatherDao.getWeather()
}
}

I have a PR suggestion to make an icon in the toolbar of the home screen to share weather information across apps using sharesheet. If it's okay, please assign me for this issue.@mayokunthefirst
Thanks in advance.

Write more unit and integration tests

TODO:

• Write Unit Tests
• Write Integration Tests

Hi all
Can you provide indexes from Algolia?

if you are on S+ android api you may get this error so in notification helper you can update pending intent to check if current sdk is higher than S api

val pendingIntent: PendingIntent = PendingIntent.getActivity(
context,
0,
intent,
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {
FLAG_IMMUTABLE
} else {
0
}
)

Version: 1.0

Current main version is not support Mac m1 chip