GithubHelp home page GithubHelp logo

Comments (10)

mediaslave avatar mediaslave commented on August 22, 2024

Hi,

Has this issue been fixed?

The patch seems to be at:

http://www.travisdunn.com/improving-tag-ownership-in-acts_as_taggable_on

from acts-as-taggable-on.

neongrau avatar neongrau commented on August 22, 2024

deosnt look like it.
i can't even get it with that patch to work: :(
is there any other tagging plugin that supports tag ownership to users?

from acts-as-taggable-on.

mediaslave avatar mediaslave commented on August 22, 2024

I don't know. Not that I have seen. Maybe we need to pay them to get them working on it...;)

from acts-as-taggable-on.

neongrau avatar neongrau commented on August 22, 2024

i got it to work with the fix, problem was the validation for tag uniquness in the Tagging Model, i added tagger_id to scope, then it worked.

validates_uniqueness_of :tag_id, :scope => [:tagger_id, :taggable_type, :taggable_id, :context]

from acts-as-taggable-on.

mediaslave avatar mediaslave commented on August 22, 2024

That is great news. I will try it from this end. I wonder if this effects any other functionality by doing what you did.

Regards,

from acts-as-taggable-on.

mediaslave avatar mediaslave commented on August 22, 2024

@neongrau this did not work for me. Are you certain that this is working for you?

from acts-as-taggable-on.

mediaslave avatar mediaslave commented on August 22, 2024

Are you going to provide a patch to devs?

from acts-as-taggable-on.

neongrau avatar neongrau commented on August 22, 2024

beside the validation everything is taken from travis dunn's blog.

i just included it differently, i made an evil-twin-plugin (script/generate plugin acts_as_taggable_fixes) with this in the main file: http://pastie.org/807240

require the file in the plugins init.rb

then i had to made sure that new plugin is properly named to come after the original plugin.

rename the folder from acts-as-taggable-on to -> acts_as_taggable_on
to make it fit current rails naming scheme and have it before the fix in load order.
google for "evil twin plugin" if you don't know what i'm talking about.

from acts-as-taggable-on.

 avatar commented on August 22, 2024

This should be fixed now.

from acts-as-taggable-on.

mediaslave avatar mediaslave commented on August 22, 2024

@i76 This is not fixed. There is still a bug.

Example:

User x, y and z

User x tags -> user z with 'php'
User y tags -> user z with 'php and 'hacker'
This works, but...
User y changes his mind tags -> user z with 'hacker' and NOT 'php'

user x and user y's 'php' tag is deleted from the taggings table

I that is clear. Let me know.

from acts-as-taggable-on.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.