mbleigh / acts-as-taggable-on Goto Github PK

what about rating cache? It's strictly necessary when showing 50 scores at once.

ghandal, implemented it in a simple but working way, why not pull him?

http://github.com/ghandal/acts_as_rateable/commit/1aa8f2ba6e79e55541b76e7f69093c3f26ffd1a3

After updating the code to reflect the changes in 2.0.0 I had to revert to the previous version (1.1.9) because find_related_* method cannot be found (rails 2.3.6)

User class defines

acts_as_taggable_on :tastes, :bands

but user.find_related_bands is not an existent method anymore.

Hi,

This a great plugin. Here two small bugs.

in : find_options_for_find_tagged_with()
change : conditions << sanitize_sql(["context = ?",on.to_s])
to : conditions << sanitize_sql(["#{Tagging.table_name}.context = ?",on.to_s])

in : find_options_for_tag_counts()
change:
{ :select => "#{Tag.table_name}.id, #{Tag.table_name}.name, COUNT() AS count",
:joins => joins.join(" "),
:conditions => conditions,
:group => group_by
}
to :
{ :select => "#{Tag.table_name}.id, #{Tag.table_name}.name, COUNT() AS count",
:joins => joins.join(" "),
:conditions => conditions,
:group => group_by,
:order => options[:order]
}

Best regards,

miguel cabero

Hi,

Has this issue been fixed?

http://www.travisdunn.com/improving-tag-ownership-in-acts_as_taggable_on

Hi, I semed to have gotten acts-as-taggable-on to work to allow me to tag the model Vendor, made an upgrade to Ruby 1.8.7 and now I get this error:

Unknown action

No action responded to tag. Actions: add_review, create, destroy, edit, index, new, rate, show, tag_cloud, and update

Here's the controller for Vendor:

http://github.com/allyforce/RQ-Upload/blob/master/app/controllers/vendors_controller.rb

Here it is for tag:

http://github.com/allyforce/RQ-Upload/blob/master/app/controllers/tags_controller.rb

Yet I am getting an Action Controller: Exception caught error....

Some ideas? Thanks.

I am not sure if this is a desired behavior or not, but it seems like the find_related*for methods is not what it should be.

If I say user.find_related_skills_for(Pet), I would expect it to return Pets that have a similar set of tags for the "skills" context.

Instead, you get any Pets that have ANY tags that the user has in it's skills context. If a user's skill is "eating" and a pet's "hobby" is eating, this matches.

Here is a failing spec as an example.

it "should only find related objects based on the tag names in the same context" do
  taggable1 = TaggableModel.create!(:name => "Taggable 1")
  taggable2 = OtherTaggableModel.create!(:name => "Taggable 2")

  taggable1.language_list = "english, french"
  taggable1.save

  taggable2.need_list = "food, water, english"
  taggable2.save

  taggable1.find_related_languages_for(OtherTaggableModel).should_not include(taggable2)  
end

Is this the desired behavior, or is this a bug?

Incorrectly process tag lists with two or more quotation marks.
See: http://gist.github.com/262434

Page.tagged_with('see').first.id
=> 107 # correct

Category.first.pages.tagged_with('see').first.id
=> 46 # incorrect. this is the ID of the Taggable object in question.

I am working on a project and noticed that the #tags_on method does a Tagging.find every time it is called.

Since the context is known (it is a parameter to the method), won't it make more sense to call the self.<context_tags> association to get those?

For example: Assume I have a user that is acts_as_taggable_on :tags

If I eagerly load the tags association using user = User.find(...., :include => :tags),
then I call user.tag_list, it still does a Tagging#find. So instead of using the eagerly loaded association, it will find the tags all over again effectively overriding my optimization.

My proposal would be to replace the finder code in the #tags_on method with a self.send(:context)

Any thoughts on this?

1.1.5 doesn't work with Rails 3 beta. I tried to manually set it up in my application, copying migration file etc, but there was just too many problems getting it to work.

Any plans on creating a new branch/version for rails 3 support? I guess supporting 3 and 2.x in the same source is a bad choice.

Thanks Glenn

http://github.com/mbleigh/acts-as-taggable-on/issues/closed#issue/24

@i76 This is not fixed. There is still a bug.

Example:

User x, y and z

User x tags -> user z with 'php'
User y tags -> user z with 'php and 'hacker'
This works, but... User y changes his mind tags -> user z with 'hacker' and NOT 'php'

user x and user y's 'php' tag is deleted from the taggings table

If that is clear. Let me know.

from what i understand a tag is upposed to be unique in the tags table but then references per user that are set "acts_as_tagger" should be stored in the taggings table.

but what the plugin currently does is not save any further taggings for different users when the tag already exists. therefor tag.count always stays at 1 making tag clouds quite boring :(

is this a bug or did i miss s.th. ?

Hi, I'm trying to use your gem with rails 3 using the 2.0.0.pre1 version

• after installation the migration should be generated with "./script/rails generate acts_as_taggable_on:migration"
• when I run it, I have a
  /Library/Ruby/Gems/1.8/gems/acts-as-taggable-on-2.0.0.pre1/lib/generators/acts_as_taggable_on/migration/migration_generator.rb:14:in join': can't convert Symbol into String (TypeError) from /Library/Ruby/Gems/1.8/gems/acts-as-taggable-on-2.0.0.pre1/lib/generators/acts_as_taggable_on/migration/migration_generator.rb:14:insource_root'
  from /Library/Ruby/Gems/1.8/gems/thor-0.13.4/lib/thor/actions.rb:34:in source_paths_for_search' from /Library/Ruby/Gems/1.8/gems/thor-0.13.4/lib/thor/actions.rb:115:insource_paths'

I was trying out the AATO gem and found that when I tried to use the #find_related_??? method I was getting the following error:

ActiveRecord::StatementInvalid: PGError: ERROR:  column "users.name" must appear in the GROUP BY clause or be used in an aggregate function
: SELECT users.*, COUNT(tags.id) AS count FROM users, tags, taggings WHERE (users.id != 1 AND users.id = taggings.taggable_id AND taggings.taggable_type = 'User' AND taggings.tag_id = tags.id AND tags.name IN (E'CSS',E'XHTML',E'HTML',E'Javascript',E'Rails',E'Ruby'))  GROUP BY users.id ORDER BY count DESC

My configuration looks like this:

# == Schema Information
#
# Table name: users
#
#  id         :integer         not null, primary key
#  name       :string(255)
#  created_at :datetime
#  updated_at :datetime
#
class User < ActiveRecord::Base
  acts_as_taggable_on :skill
end

I tracked the problem to line 280 in the lib/acts_as_taggable_on/acts_as_taggable_on.rb file. I am not sure if this is something that only happens in Postgres or if it is being seen elsewhere. I had to update the line to be

:select => "#{klass.table_name}.id, COUNT(#{Tag.table_name}.id) AS count"

instead of

:select => "#{klass.table_name}.*, COUNT(#{Tag.table_name}.id) AS count"

I am testing this on an iMac running 10.6.1 with Postgresql 8.3.8. Anyway, other than this minor issue I am very pleased with the gem. Thanks for the great work!

when merging conditions string parentheses should be placed around clauses with OR.
Example:

currently User.tagged_with("foo, bar", :as => :languages) will result in the following query:
SELECT .... WHERE (context = 'languages' AND users_tags.name LIKE 'foo' OR users_tags.name LIKE 'bar')

Note that it will improperly match 'bar' tag in any context.

Hi,
there are conflict of your plugin and vestal_versions.With both plugins added to project i see following error

            $ ./script/generate
            /opt/local/lib/ruby/gems/1.8/gems/rails-2.3.5/lib/rails/
            gem_dependency.rb:119:Warning: Gem::Dependency#version_requirements is
            deprecated and will be removed on or after August 2010.  Use
            #requirement
            /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.5/lib/active_record/
            reflection.rb:187:in `quoted_table_name': undefined method
            `quoted_table_name' for VestalVersions::Tagging:Module (NoMethodError)
                    from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.5/lib/
            active_record/associations.rb:1416:in
            `configure_dependency_for_has_many'
                    from /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.5/lib/
            active_record/associations.rb:824:in `has_many'
                    from (eval):3:in `has_many'
                    from /opt/local/lib/ruby/gems/1.8/gems/mbleigh-acts-as-
            taggable-on-1.0.5/lib/acts_as_taggable_on/acts_as_taggable_on.rb:25:in
            `acts_as_taggable_on'
                    from /opt/local/lib/ruby/gems/1.8/gems/mbleigh-acts-as-
            taggable-on-1.0.5/lib/acts_as_taggable_on/acts_as_taggable_on.rb:24:in
            `class_eval'
                    from /opt/local/lib/ruby/gems/1.8/gems/mbleigh-acts-as-
            taggable-on-1.0.5/lib/acts_as_taggable_on/acts_as_taggable_on.rb:24:in
            `acts_as_taggable_on'
                    from /opt/local/lib/ruby/gems/1.8/gems/mbleigh-acts-as-
            taggable-on-1.0.5/lib/acts_as_taggable_on/acts_as_taggable_on.rb:20:in
            `each'
                    from /opt/local/lib/ruby/gems/1.8/gems/mbleigh-acts-as-
            taggable-on-1.0.5/lib/acts_as_taggable_on/acts_as_taggable_on.rb:20:in
            `acts_as_taggable_on'

One guy have recommended me to rename model Tagging to the ::Tagging - it solved the problem. I'd like to ask you to rename model Tagging to the other one to solve any problem. Thanks.

For exemple, if you have an application with contacts and you want to put tags on then:

c1 = Contact.find(1)
c1.tag_list = "friend"
c1.save

c2 = Contact.find(2)
c2.tag_list = "client"
c2.save

If you search for Contact.tagged_with("client", :on => :tags), it will return an array containing a contact equivalent to c2. This will work perfectly until someone do the next thing:

c3 = Contact.find(3)
c3.tag_list = "client friend" #with no comma
c3.save

If you search for Contact.tagged_with("client", :on => :tags) again, it will return []

From the examples listed in the README..
@some_user.tag(@some_photo, :with => "paris, normandy", :on => :locations)

My config:
Rails 2.3.5
acts-as-taggable-on --version=1.1.7
(because the master branch does not pass all the tests...)

My classes:
class Mark < ActiveRecord::Base
acts_as_taggable_on :tags, :labels
end

class User < ActiveRecord::Base
  acts_as_tagger
  acts_as_authentic
end

This is my script/console output.

>> m = Mark.create :name => "first mark", :url => 'http://example.com'
=> #<Mark id: 97, name: "first mark", url: "http://example.com", note: nil, created_at: "2010-03-19 06:26:51", updated_at: "2010-03-19 06:26:51">
>> m.tags
=> []
>> m.labels
=> []
>> m.label_list = "star, first"
=> "star, first"
>> m.tag_list = 'white, blue'
=> "white, blue"
>> m.save!
=> true
>> m.reload
=> #<Mark id: 97, name: "first mark", url: "http://example.com", note: nil, created_at: "2010-03-19 06:26:51", updated_at: "2010-03-19 06:26:51">
>> m.tags
=> [#<Tag id: 25, name: "white">, #<Tag id: 26, name: "blue">]
>> m.labels
=> [#<Tag id: 23, name: "star">, #<Tag id: 27, name: "first">]
>> m.tag_list
=> ["white", "blue"]
>> m.label_list
=> ["star", "first"]


>> u = User.find :first
=> #<User id: 1, username: "me", email: "[email protected]", ...>
>> u.tag(m, :with => 'funny', :on => :tags)
=> true
>> m.reload
=> #<Mark id: 97, name: "first mark", url: "http://example.com", note: nil, created_at: "2010-03-19 06:26:51", updated_at: "2010-03-19 06:26:51">
>> m.tags
=> [#<Tag id: 25, name: "white">, #<Tag id: 26, name: "blue">, #<Tag id: 28, name: "funny">]
>> m.tag_list
=> ["white", "blue"]
>> # the above should be ["white", "blue", "funny"]

This is relatively minor, but we did run into it.

TagList.from("...") strips quotations marks out of tags, which would ordinarily make sense.

But if a user creates a new tag with quotation marks, they are not stripped out.

This results in a bit of confusion, if a user tags something with "abc" (including quotes) and then does a search which calls Object.find_tagged_with(param[:search]) the search will return zero results because inside find_tagged_with it calls TagList.from which strips the quotes out of the search.

One fix would be to have Tag strip quotes out when new ones are creatd (it probably doesn't normally make sense to have tags with quotes in them, but it does in our case since tags are keywords, just like Google keyword searches where you sometimes want to use quotes, admittedly a special case).

A quick fix in our case:

Comments out the 2 string.gsub! lines in TagList.from, around line 82 and 83.

Hope it helps someone, and great plugin!

new_tag_names = list.reject { |name| existing_tags.any? { |tag| tag.name.downcase == name.downcase } }

code above work incorrectly with unicode tag names. Names should be downcased with mb_chars.downcase

here is the patch:
http://github.com/yury/acts-as-taggable-on/commit/31385691e989e2b15ddab1d318d673f4cb69ef4e
Can't write test to reproduce problem, because sqlite LIKE is case sensitive with unicode chars.

Subject :)

Not an issue but really, I have a bunch of other plugins in my vendor folder and acts_as_taggable_on is the only one which proudly announces himself in the logs.

The find_related_ methods are only available if you include the acts_as taggable as well

class User < ActiveRecord::Base
   acts_as_taggable   
   acts_as_taggable_on :tags, :skills, :interests
end

It is included in your rspec models, so the tests are successful. I think it would therefore be enough to add it in your README.

Hello mbleigh,

Can you move the gem to gemcutter.org?

http://gems.github.com/ doesn't work anymore :)

Thanks

As pointed out by Stuart Henry https://mbleigh.lighthouseapp.com/projects/10116-acts-as-taggable-on/tickets/49-add-count-column-to-tags-table#ticket-49-2, the count column is not included in acts_as_taggable_on_migration. Consequently, tag counts aren't returned for User.skill_counts, etc.

To fix after the fact create a migration that includes the following:
add_column :tags, :count, :integer, :default => 0

Hello,

why the gem doesn't embed the generator ?

Thanks
Franck

Hi,

Starting to use acts-as-taggable-on and easing in using as if on-steroids and get a "context" error.

class Vendor...
acts_as_taggable_on :tags, :competitors

form_for @Vendor |do|....

<%= f.label :tags %>
<%= f.text_field :tag_list %>

It looks like I have added it as the model with two types of context

And then in the view new created a field for submission.

But I'm still getting an error. Thanks!

Introduced in 42b51e3, there is bug saving STI models. There should be used "self.class.base_class"

Here is a failing test and a patch:

diff --git a/lib/acts_as_taggable_on/acts_as_taggable_on.rb b/lib/acts_as_taggable_on/acts_as_taggable_on.rb
index cbd83b8..ccb28de 100644
--- a/lib/acts_as_taggable_on/acts_as_taggable_on.rb
+++ b/lib/acts_as_taggable_on/acts_as_taggable_on.rb
@@ -398,12 +398,12 @@ module ActiveRecord

               cache.each do |owner, list|
                 new_tags = Tag.find_or_create_all_with_like_by_name(list.uniq)
-                taggings = Tagging.find(:all, :conditions => { :taggable_id => self.id, :taggable_type => self.class.to_s })
+                taggings = Tagging.find(:all, :conditions => { :taggable_id => self.id, :taggable_type => self.class.base_class.to_s })

                 # Destroy old taggings:
                 if owner
                   old_tags = tags_on(context, owner) - new_tags
-                  old_taggings = Tagging.find(:all, :conditions => { :taggable_id => self.id, :taggable_type => self.class.to_s, :tag_id => old_tags, :tagger_id => owner.id, :tagger_type => owner.class.to_s, :context => context })
+                  old_taggings = Tagging.find(:all, :conditions => { :taggable_id => self.id, :taggable_type => self.class.base_class.to_s, :tag_id => old_tags, :tagger_id => owner.id, :tagger_type => owner.class.to_s, :context => context })

                   Tagging.destroy_all :id => old_taggings.map(&:id)
                 else
diff --git a/spec/acts_as_taggable_on/taggable_spec.rb b/spec/acts_as_taggable_on/taggable_spec.rb
index a23014e..b82c905 100644
--- a/spec/acts_as_taggable_on/taggable_spec.rb
+++ b/spec/acts_as_taggable_on/taggable_spec.rb
@@ -247,5 +247,15 @@ describe "Taggable" do
       AlteredInheritingTaggableModel.tag_counts_on(:tags).map(&:name).should == %w(fork spoon)
       TaggableModel.tag_counts_on(:tags).map(&:name).should == %w(bob kelso fork spoon)
     end
+    
+    it 'should store same tag without validation conflict' do
+      @taggable.tag_list = 'one'
+      @taggable.save!
+      
+      @inherited_same.tag_list = 'one'
+      @inherited_same.save!
+      
+      @inherited_same.update_attributes! :name => 'foo'
+    end
   end
 end

suppose a User model has acts_as_taggable_on :bands

  user.band_list = ["ac\\dc"]
  user.save!

Will raise:
ActiveRecord::RecordInvalid: Validation failed: Tag can't be blank
on
acts_as_taggable_on.rb:423:in `save_tags'

Is anyone else seeing this?

When I pass tagged_with a tag that does not exist, it returns every record (instead of none).

>> Website.tagged_with("some tag that does not exist", :on=>:tags).size
=> 239
>> Website.count
=> 239

Acts as taggable joins with the tags tables, and thus the records found are marked ActiveRecord::ReadOnlyRecord. An option to return writeable records is needed. If anything this caveat should be mentioned in the docs.

Extending models Tag and Tagging is impossible. Opening these classes just doesn't work.
So is it possible to remove them from gem lib and add them to generator who will copy those two files to models directory?

This would be a huge change for all users, but I think it's worth discussion.
What do you think?

With this model code:

acts_as_taggable_on :categories

I get a model that supports self.categories. The tag context acts kind of like a has_many association. Good.

But when I add:

accepts_nested_attributes_for :categories

and POST a list of categories to the create action I get this exception deep in AR#new:

ActiveRecord::AssociationTypeMismatch in 'PlacesController authenticated user should process categories parameter to create'
Tag(#2176796520) expected, got String(#2148246520)
/Library/Ruby/Gems/1.8/gems/activerecord-2.3.4/lib/active_record/associations/association_proxy.rb:263:in raise_on_type_mismatch' /Library/Ruby/Gems/1.8/gems/activerecord-2.3.4/lib/active_record/associations/association_collection.rb:320:inreplace'
/Library/Ruby/Gems/1.8/gems/activerecord-2.3.4/lib/active_record/associations/association_collection.rb:320:in each' /Library/Ruby/Gems/1.8/gems/activerecord-2.3.4/lib/active_record/associations/association_collection.rb:320:inreplace'
/Library/Ruby/Gems/1.8/gems/activerecord-2.3.4/lib/active_record/associations.rb:1322:in `categories='

It appears that the association is looking for Tag objects and won't accept the Strings I'm handing it.

Hello,

Is it possible to do something like this:

image.rb
act_as_taggable_on :galleries

In console:
User.first.tag(User.first.images.last, :with => "first, second, third", :on => :galleries)
User.first.images.last.galleries # => "Would return all 'galleries' (tags) from that image"

Now it produces an SQL like this:
SELECT tags.* FROM tags INNER JOIN taggings ON tags.id = taggings.tag_id WHERE ((taggings.taggable_id = 2059) AND (taggings.taggable_type = 'Image') AND ((taggings.tagger_id IS NULL AND taggings.context = 'galleries')))

As You can see he is looking for a User which IS NULL and that will never take my galleries :)

I know, I can use a:
User.first.images.last.galleries_from(User.first) # => ["first", "second", "third"]
It returns an Array but I wanted easily get all Tag objects.

I don't want to achieve it like this:
User.first.images.last.galleries_from(User.first).collect{ |g| Tag.find_by_name(g) }

How can I make it at the moment? Do I need to make some patch to achieve this?

Best,
Martin

I am using ActiveScaffold, and when It loads up a list of my model objects it fails on the has_many. It appears that the aliased_join_table_name is not being defaulted to "taggings". The following change fixed it locally for me:
acts_as_taggable_on.rb (line 26)
was
:include => :tag, :conditions => ['#{aliased_join_table_name rescue "taggings"}.context = ?',tag_type], :class_name => "Tagging"
changed to
:include => :tag, :conditions => ['#{aliased_join_table_name || "taggings" rescue "taggings"}.context = ?',tag_type], :class_name => "Tagging"

When I run a tag seach with :match_all => true I get the following error.

ActiveRecord::StatementInvalid (PGError: ERROR:  column "entries.id" must appear in the GROUP BY clause or be used in an aggregate function
: SELECT DISTINCT entries.* FROM "entries"  LEFT OUTER JOIN taggings entries_taggings ON entries_taggings.taggable_id = entries.id AND entries_taggings.taggable_type = E'Entry' LEFT OUTER JOIN tags entries_tags ON entries_tags.id = entries_taggings.tag_id WHERE ((context = E'tags' AND entries_tags.name LIKE E'abandoned stairs') AND ("entries"."status" = E'published'))  GROUP BY entries_taggings.taggable_id HAVING COUNT(entries_taggings.taggable_id) = 1 ORDER BY published_at DESC LIMIT 30 OFFSET 0):

I upgraded from Rails 2.2.2 to 2.3.4 & got this error from this plugin when loading an AR class with acts_as_taggable in it:

ArgumentError ArgumentError: wrong number of arguments (2 for 1)
from /opt/ruby-enterprise/lib/ruby/gems/1.8/gems/activerecord-2.3.4/lib/active_record/associations.rb:1414:in `sanitize_sql'
        from /opt/ruby-enterprise/lib/ruby/gems/1.8/gems/activerecord-2.3.4/lib/active_record/associations.rb:1414:in `configure_dependency_for_has_many'
        from /opt/ruby-enterprise/lib/ruby/gems/1.8/gems/activerecord-2.3.4/lib/active_record/associations.rb:823:in `has_many'
        from (eval):3:in `has_many'
        from RAILS_ROOT/vendor/plugins/acts-as-taggable-on/lib/acts_as_taggable_on/acts_as_taggable_on.rb:25:in `acts_as_taggable_on'

I was able to fix this by downgrading to 2.3.2 - any insights?

Using this plugin version 1.0.11
Issue 17 solution did not work for me

I am not sure if I am using the gem correctly or if it is the intended use, but if I try to find all records with tagged "A" or "B" by calling Users.tagged_with("A, B", :on => :skills) it only returns User with both A and B and not the User tagged with "A" and the User tagged with "B".

tag_counts should work like find, so if I pass a condition:
Challenge.tag_counts/_on(:tags, :conditions => {:opened => false}) // or :conditions => ['challenge.opened = ?', false]

just merges the strings improperly : "challenge.opened = ? false" resulting in bad query. seems to me that options.merge({.. is not needed when that can be achieved with_scope.. Will play with this today..

    def tag_counts_on(context, options = {})
       with_scope :find => options do
         Tag.find(:all, find_options_for_tag_counts(:on => context.to_s))
       end
    end           

In my app for example, top_tags doesn't recognize limits (even when trying different ways such as :limit => 3) and just lists all tags:

b = Blog.find_by_slug 'paulstamatiou-com'
b.top_tags(3)
[#<Tag id: 6, name: "software">, #<Tag id: 15, name: "Apple">, #<Tag id: 32, name: "programming">, #<Tag id: 49, name: "web">, #<Tag id: 220, name: "tech">, #<Tag id: 234, name: "Internet">, #<Tag id: 303, name: "ruby">]

Hi,
is it possible to support friendly url like in this gem http://github.com/norman/friendly_id ?
Name of the tag instead of the id in the url (and in the searching etc.)
Thanks
Petr

In view:
<%= form.label :tags %>
or
<%= form.label :tag_list %>
Object is created successfully. But when editing get an error:
ActiveRecord:: RecordInvalid (Validation failed: Tag has already been taken)
What do I do?

passed-in conditions are not being sanitized, causing some funky behavior with bound parameters; ex: :conditions => [ "foo.id IN (?)", [1,2,3,4,5] ] is being converted to SQL " foo.id in (?) AND 1 AND 2 AND 3 AND 4 AND 5"

here's a fix I applied that appears to be working:
before:
conditions = [
taggable_type,
taggable_id,
options[:conditions],
start_at,
end_at
]

after:
conditions = [
taggable_type,
taggable_id,
sanitize_sql(options[:conditions]),
start_at,
end_at
]

Thanks for your great plugin! I really like it. My question is: how to use will_paginate with find_related_xxx()? I'm not sure it's an issue or not. Thanks.
6yf

The problem starts at line 161 of acts_as_taggable_on.rb:

tags = Tag.named_like_any(tag_list)
return { :conditions => "1 = 0" } unless tags.length == tag_list.length

WTF!?!!

This will cause no records to return if you do a tagged_with('foo') if you have tags 'foo', 'foo bar', 'food'. I would attempt to patch this, but I have no idea what behavior is trying to be achieved here.

After updating the code to reflect the changes in 2.0.0 I had to revert to the previous version (1.1.9) because find_related_* method cannot be found (rails 2.3.6)

User class defines

acts_as_taggable_on :tastes, :bands

but user.find_related_bands is not an existent method anymore.

It would be very nice if setting the “tag_list” attribute would support the dirty tracking available in ActiveRecord since Rails 2.1:

```
my_model = MyModel.create :tag_list => ‘ruby’
my_model.tag_list = ‘ruby, rails’
my_model.changed? # true
my_model.tag_list_changed? # true
my_model.tag_list_change # [“ruby”, “ruby, rails”]
my_model.changes # {"tag_list"=>[“ruby”, “ruby, rails”]}
```

With such an enhancement, the plugin collectiveidea/acts_as_audited could track changes of tags.

The first lines at http://github.com/mbleigh/acts-as-taggable-on/blob/feature/rails3_compatibility/lib/acts-as-taggable-on.rb seems to break my deployment to Heroku. These are the lines which I've been told are breaking the deployment and shouldn't be there:

begin
  # Try to require the preresolved locked set of gems.
 require File.expand_path("../.bundle/environment", __FILE__)
rescue LoadError
  # Fall back on doing an unlocked resolve at runtime.
  require "rubygems"
  require "bundler"
  Bundler.setup
end

I just wanted to bring some light upon this.

Thanks.

If I call tagged_with without specifying options, I get an exception thrown:

ArgumentError: wrong number of arguments (1 for 2)
from vendor/plugins/acts-as-taggable-on/lib/acts_as_taggable_on/acts_as_taggable_on.rb:90

I just installed the plugin today; this is a Rails 2.3.2 project.

Here's my proposed patch:

named_scope :tagged_with, lambda{ |tags, *options|
  options = options.shift || {}
  find_options_for_find_tagged_with(tags, options)
}

As shown below, chaining the tagged_with named scope doesn't appear to work, at least not in the way I'm doing it. What nomenclature do I used to find all Products that are tagged with both "081" and "20x24"?

Thanks.
c.

>> Product.find(1).tags.map {|t| t.name}
=> ["081", "20x24", "aluminum", "forever", "frame"]
>> Product.tagged_with("081", {}).size
=> 24
>> Product.tagged_with("20x24", {}).size
=> 94
>> Product.tagged_with("20x24, 081", {}).size
=> 118
>> Product.tagged_with("081", {}).tagged_with("20x24", {}).size
=> 0

Code:

class Post
acts_as_taggable_on :tags

class Comment
belongs_to :post, :touch => true
end

post = Post.create(:tag_list => "one, two")
post.comments.create! # UPDATE posts Set updated_at = 'now()' cached_tag_list = '' ...
post.reload
post.tag_list # => []