mbrukman / openmpt

Official experimental read-only git mirror of the OpenMPT and libopenmpt subversion repository at https://source.openmpt.org/. This repository may occasionally get rebased without further notice when subversion revision properties (commit message) get fixed in recent history after the fact. Be sure to rebase often in case you clone or fork it.

README

OpenMPT and libopenmpt

How to compile

OpenMPT

• Supported Visual Studio versions:

  • Visual Studio 2015 Update 3 Community/Professional/Enterprise

    To compile the project, open build/vs2015/OpenMPT.sln and hit the compile button.

  • Visual Studio 2017 Community/Professional/Enterprise

    To compile the project, open build/vs2017/OpenMPT.sln and hit the compile button.

• The VST and ASIO SDKs are needed for compiling with VST and ASIO support.

  If you don't want this, uncomment #define NO_VST and comment out #define MPT_WITH_ASIO in the file common/BuildSettings.h.

  The ASIO and VST SDKs can be downloaded automatically on Windows 7 or later with 7-Zip installed by just running the build/download_externals.cmd script.

  If you do not want to or cannot use this script, you may follow these manual steps instead:

  • ASIO:

    If you use #define MPT_WITH_ASIO, you will need to put the ASIO SDK in the include/ASIOSDK2 folder. The top level directory of the SDK is already named ASIOSDK2, so simply move that directory in the include folder.

    Please visit steinberg.net to download the SDK.

  • VST:

    If you don't use #define NO_VST, you will need to put the VST SDK in the include/vstsdk2.4 folder.

    Simply copy all files from the VST3 SDK folder in the SDK .zip file to include/vstsdk2.4/.

    Note: OpenMPT makes use of the VST 2.4 specification only. The VST3 SDK still contains all necessary files in the right locations. If you still have the old VST 2.4 SDK laying around, this should also work fine.

    Please visit steinberg.net to download the SDK.

  If you need further help with the VST and ASIO SDKs, get in touch with the main OpenMPT developers.

• 7-Zip is required to be installed in the default path in order to build the required files for OpenMPT Wine integration.

  Please visit 7-zip.org to download 7-Zip.

libopenmpt and openmpt123

For detailed requirements, see libopenmpt/dox/quickstart.md.

• Autotools

  Grab a libopenmpt-VERSION-autotools.tar.gz tarball.

  ./configure
  make
  make check
  sudo make install
  

• Visual Studio:

  • You will find solutions for Visual Studio 2015 to 2017 in the corresponding build/vsVERSION/ folder. Projects that target Windows versions before Windows 7 are available in build/vsVERSIONxp/ Most projects are supported with any of the mentioned Visual Studio verions, with the following exceptions:

    • in_openmpt: Requires Visual Studio with MFC.

    • xmp-openmpt: Requires Visual Studio with MFC.

  • You will need the Winamp 5 SDK and the XMPlay SDK if you want to compile the plugins for these 2 players. They can be downloaded automatically on Windows 7 or later with 7-Zip installed by just running the build/download_externals.cmd script.

    If you do not want to or cannot use this script, you may follow these manual steps instead:

    • Winamp 5 SDK:

      To build libopenmpt as a winamp input plugin, copy the contents of WA5.55_SDK.exe to include/winamp/.

      Please visit winamp.com to download the SDK. You can disable in_openmpt in the solution configuration.

    • XMPlay SDK:

      To build libopenmpt with XMPlay input plugin support, copy the contents of xmp-sdk.zip into include/xmplay/.

      Please visit un4seen.com to download the SDK. You can disable xmp-openmpt in the solution configuration.

• Makefile

  The makefile supports different build environments and targets via the CONFIG= parameter directly to the make invocation. Use make CONFIG=$newconfig clean when switching between different configs because the makefile cleans only intermediates and target that are active for the current config and no configuration state is kept around across invocations.

  • mingw-w64:

    The required version is at least 4.8.

    make CONFIG=mingw64-win32    # for win32
    
    make CONFIG=mingw64-win64    # for win64
    

  • gcc or clang (on Unix-like systems, including Mac OS X with MacPorts):

    The minimum required compiler versions are:

    • gcc 4.8

    • clang 3.4

    The Makefile requires pkg-config for native builds. For sound output in openmpt123, PortAudio or SDL is required. openmpt123 can optionally use libflac and libsndfile to render PCM files to disk.

    When using gcc, run:

    make CONFIG=gcc
    

    When using clang, it is recommended to do:

    make CONFIG=clang
    

    Otherwise, simply run

    make
    

    which will try to guess the compiler based on your operating system.

  • emscripten (on Unix-like systems):

    libopenmpt has been tested and verified to work with emscripten 1.31 or later (earlier versions might or might not work).

    Run:

    make CONFIG=emscripten
    

    Running the test suite on the command line is also supported by using node.js. Version 0.10.25 or greater has been tested. Earlier versions might or might not work. Depending on how your distribution calls the node.js binary, you might have to edit build/make/config-emscripten.mk.

  • Haiku:

    To compile libopenmpt on Haiku (using the 32-bit gcc2h), run:

    make CONFIG=haiku
    

  • American Fuzzy Lop:

    To compile libopenmpt with fuzzing instrumentation for afl-fuzz, run:

    make CONFIG=afl
    

    For more detailed instructions, read contrib/fuzzing/readme.md

  • other compilers:

    To compiler libopenmpt with other C++11 compliant compilers, run:

    make CONFIG=generic
    

  The Makefile supports some customizations. You might want to read the top which should get you some possible make settings, like e.g. make DYNLINK=0 or similar. Cross compiling or different compiler would best be implemented via new config-*.mk files.

  The Makefile also supports building doxygen documentation by using

  make doc
  

  Binaries and documentation can be installed systen-wide with

  make PREFIX=/yourprefix install
  make PREFIX=/yourprefix install-doc
  

  Some systems (i.e. Linux) require running

  sudo ldconfig
  

  in order for the system linker to be able to pick up newly installed libraries.

  PREFIX defaults to /usr/local. A DESTDIR= parameter is also supported.

• Android NDK

  See build/android_ndk/README.AndroidNDK.txt.

Coding conventions

OpenMPT

(see below for an example)

• Functions / methods are "underlined" (The //------ comment, see below for an example what it should look like).
• Place curly braces at the beginning of the line, not at the end
• Generally make use of the custom index types like SAMPLEINDEX or ORDERINDEX when referring to samples, orders, etc.
• When changing playback behaviour, make sure that you use the function CSoundFile::IsCompatibleMode() so that modules made with previous versions of MPT still sound correct (if the change is extremely small, this might be unnecessary)
• CamelCase function and variable names are preferred.

OpenMPT code example

void Foo::Bar(int foobar)
//-----------------------
{
    while(true)
    {
        // some code
    }
}

libopenmpt

Note: This applies to libopenmpt/ and openmpt123/ directories only. Use OpenMPT style (see above) otherwise.

The code generally tries to follow these conventions, but they are not strictly enforced and there are valid reasons to diverge from these conventions. Using common sense is recommended.

• In general, the most important thing is to keep style consistent with directly surrounding code.
• Use C++ std types when possible, prefer std::size_t and std::int32_t over long or int. Do not use C99 std types (e.g. no pure int32_t)
• Qualify namespaces explicitly, do not use using. Members of namespace openmpt can be named without full namespace qualification.
• Prefer the C++ version in namespace std if the same functionality is provided by the C standard library as well. Also, include the C++ version of C standard library headers (e.g. use <cstdio> instead of <stdio.h>.
• Do not use ANY locale-dependant C functions. For locale-dependant C++ functionaly (especially iostream), always imbue the std::locale::classic() locale.
• Prefer kernel_style_names over CamelCaseNames.
• If a folder (or one of its parent folders) contains .clang-format, use clang-format v3.5 for indenting C++ and C files, otherwise:
  • { are placed at the end of the opening line.
  • Enclose even single statements in curly braces.
  • Avoid placing single statements on the same line as the if.
  • Opening parentheses are separated from keywords with a space.
  • Opening parentheses are not separated from function names.
  • Place spaces around operators and inside parentheses.
  • Align : and , when inheriting or initializing members in a constructor.
  • The pointer * is separated from both the type and the variable name.
  • Use tabs for identation, spaces for formatting. Tabs should only appear at the very beginning of a line. Do not assume any particular width of the TAB character. If width is important for formatting reasons, use spaces.
  • Use empty lines at will.
• API documentation is done with doxygen. Use general C doxygen for the C API. Use QT-style doxygen for the C++ API.

libopenmpt indentation example

namespace openmpt {

// This is totally meaningless code and just illustrates indentation.

class foo
	: public base
	, public otherbase
{

private:

	std::int32_t x;
	std::int16_t y;

public:

	foo()
		: x(0)
		, y(-1)
	{
		return;
	}

	int bar() const;

}; // class foo

int foo::bar() const {

	for ( int i = 0; i < 23; ++i ) {
		switch ( x ) {
			case 2:
				something( y );
				break;
			default:
				something( ( y - 1 ) * 2 );
				break;
		}
	}
	if ( x == 12 ) {
		return -1;
	} else if ( x == 42 ) {
		return 1;
	}
	return 42;

}

} // namespace openmpt