mcb2001 / csharp.ulid Goto Github PK

Firstly, thanks for putting this library together.

Based on my reading of the code (not testing), I think that it should throw an exception if AddOne is not able to increment anything here

The spec states "If, in the extremely unlikely event that, you manage to generate more than 280 ULIDs within the same millisecond, or cause the random component to overflow with less, the generation will fail.".

PR here #8

This is a useful library and I (and likely more people) would like to consume it via NuGet.

If you could:

1. create NuGet publish key: https://docs.microsoft.com/en-us/nuget/quickstart/create-and-publish-a-package-using-the-dotnet-cli#acquire-your-api-key
2. create GH secret with NuGet publish key: https://docs.github.com/en/free-pro-team@latest/actions/reference/encrypted-secrets#creating-encrypted-secrets-for-an-organization
   • GitHub actions injects the secrets by name during the workflow run; main.yml file will only have:
     ${{ secrets.NAME_YOU_CHOSE }}

and tell me the name/alias of secret you chose, i can update the workflow with publish step, so when you will create and push a new git tag, e.g. git tag v1.0.0 && git push --tags, it will automagically publish v1.0.0 of this library to nuget.org, and also create a GitHub release for that tag.