mcdittmar / jovial Goto Github PK

INSTANCE node writes REFERENCEs before COMPOSITIONs, but the schema expects the reverse (COMPOSITON before REFERENCE).

• imported model URLs must be valid endpoints, not redirected
  • jovial loads the imported model files from the specified and does NOT follow redirects.
  • This can result in a runtime error "DOCTYPE is disallowed..." when it receives the redirect response.
    o Coords model: ivoa url => 'http' -> 'https'
    o Meas model: ivoa url => 'http' -> 'https'
    coords url => -> <ivoa_root>/STC/20200908/Coords-v1.0.vo-dml.xml

Seen in dm-usecase/usecases/column_groupings
Object contains list of references to other Object
The expected output (understood by rama) is:

<REFERENCE dmrole=blah>
<IDREF>ref1</IDREF>
<IDREF>ref2</IDREF>
etc.
</REFERENCE>

I was not able to produce the proper DSL commands to generate this output.

When generating a LITERAL under PRIMARYKEY|FOREIGNKEY, jovial has the type hardcoded to 'ivoa:string'

https://github.com/olaurino/jovial/blob/master/src/main/groovy/cfa/vo/vodml/io/votable/VotableWriter.groovy#L120

it should obtain the type from the key object: key.type.toString()

TestCase: ZTF TimeSeries example.
https://github.com/mcdittmar/dm-usecases-impl/tree/main/time-series
the source id (oid) is 'ivoa:integer' type.

In mode for generating python classes from vo-dml/XML file.

• jovial --python <vodml/xml>

It would be helpful to include a comment or doc string in the resulting module file indicating the model file used.
The filename (URL) would be a good start, but can be unreliable if working with a local copy.
Perhaps some of the metadata info from the resource file itself... (name, description, uri, etc.)