md-azmal / sharp-tune

Lightweight Cross-platform music player build upon the node using the electron framework.

#Tune

Version 1.0.3

Lightweight Cross-platform music player build upon the node using the electron framework.

Visit on electron

Screenshot

Usage

Application

• Start the Application and select File option in the Application's menu.
• Select the folder where you have the media files
• Select one from the List and enjoy!!

Contribute

• Clone the repo
• Navigate to the main folder
• Open the terminal and use npm install to install the dependencies
• npm start to start the application

Features

• LightWeight
• Supports commmon multimedia format

Whats New!

• Removed 3rd party dependecy for playing song
• Used Web Audio API
• Added Audio Visualiser

Credits

• Logo: mansya

License & Copyright

© 2018 Md Azmal

sharp-tune's Issues

new logo/icon

Hi, I am a graphic designer, I want to help others in graphic design.

After I reviewed your project, you have no logo on this project. Therefore I want to contribute to this project by creating a new logo / icon. what do you think?

fix the load time

It takes longer time to load music files and there are some glitches while playing

Cannot find module 'resources/electron.asar/browser/init.js'

module.js:545
    throw err;
    ^
Error: Cannot find module '/run/firejail/appimage/.appimage-7139/resources/electron.asar/browser/init.js'
    at Function.Module._resolveFilename (module.js:543:15)
    at Function.Module._load (module.js:473:25)
    at Function.Module.runMain (module.js:683:10)
    at startup (bootstrap_node.js:196:16)
    at bootstrap_node.js:622:3
Parent pid 7139, child pid 7142

May be caused by electron-userland/electron-builder#2958

Reference:
AppImage/appimage.github.io#658

XSS in player.js

            tmp.onloadeddata = function () {
                playList.push({
                    index: gi,
                    song: file,
                    song_name: file,
                    duration: tmp.duration
                })
                song_list.append(`<li class="list">
            <span class="index">${playList[gi].index + 1}</span>
            <span class="song">${playList[gi].song_name}</span>
            <span class="duration">${toTime(playList[gi].duration)}</span>
            </li>`);

                    playList.push({
                        index: gi,
                        song: file,
                        song_name: metadata.title || file,
                        duration: metadata.duration
                    });
                    song_list.append(`<li class="list">
                    <span class="index">${playList[gi].index + 1}</span>
                    <span class="song">${playList[gi].song_name}</span>
                    <span class="duration">${toTime(playList[gi].duration)}</span>
                    </li>`);

This is not secure, as you can just insert your own HTML/js into filename or metadata and have it execute inside the application: e.g. edit any MP3 file and set title to <script>alert('xss')</script>, and the alert box will pop up when you select a folder containing the song.