mdaffa48 / ssb2-advancedslimeworldmanager

Advanced-SlimeWorldManager add-on for SuperiorSkyblock2

Glad to see you here!

I’m a software developer and I have 3 years experience of creating Minecraft Spigot plugins.

Right now I'm on the final year of my high school and wanted to persuade college to increase my experience and skills perhaps and of course to expand my network. I'm interested in many things and always want to try something new.

Rapidfire

🏫 I’m currently in my final year of high school at SMKN 2 Bandung 💻 I’m currently learning to be a full-stack developer ❤️ I love to try something that I haven't tried before

Languages and Tools

Github Stats

ssb2-advancedslimeworldmanager's Issues

1.18.2 Support Required

Great work!

Doesn't work with 1.18.2 we need support for this version for minecraft.

Are there any plans on providing support for 1.18.2? If so when can we expect this update?

Thanks in advance!

Server Restart when create a island

When players create the island it barely takes 1 minute but the server restarts.

Error code:

https://pastebin.com/fsvJ3skJ

unload bug with ASWM on 1.18.2

It seems that the latest ASWM removed CraftSlimeWorld, maybe it changed other methods. The island doesn't save properly, the server restarts thinking I don't have an island and asks me to create it again.

[22:59:46] [Server thread/INFO]: [SuperiorSkyblock-ASWM] Disabling SuperiorSkyblock-ASWM v1.0.4
[22:59:46] [Server thread/ERROR]: Error occurred while disabling SuperiorSkyblock-ASWM v1.0.4 (Is it up to date?)
java.lang.NoClassDefFoundError: com/grinderwolf/swm/nms/CraftSlimeWorld
	at me.aglerr.ssbslimeworldmanager.utils.SlimeUtils.unloadWorld(SlimeUtils.java:109) ~[SuperiorSkyblock-ASWM-v1.0.4.jar:?]
	at me.aglerr.ssbslimeworldmanager.utils.SlimeUtils.lambda$unloadAllWorlds$0(SlimeUtils.java:39) ~[SuperiorSkyblock-ASWM-v1.0.4.jar:?]
	at java.util.HashMap$KeySet.forEach(HashMap.java:1008) ~[?:?]
	at me.aglerr.ssbslimeworldmanager.utils.SlimeUtils.unloadAllWorlds(SlimeUtils.java:37) ~[SuperiorSkyblock-ASWM-v1.0.4.jar:?]
	at me.aglerr.ssbslimeworldmanager.SSBSlimeWorldManager.onDisable(SSBSlimeWorldManager.java:30) ~[SuperiorSkyblock-ASWM-v1.0.4.jar:?]
	at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:266) ~[paper-api-1.18.2-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.plugin.java.JavaPluginLoader.disablePlugin(JavaPluginLoader.java:399) ~[paper-api-1.18.2-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.plugin.SimplePluginManager.disablePlugin(SimplePluginManager.java:578) ~[paper-api-1.18.2-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.plugin.SimplePluginManager.disablePlugins(SimplePluginManager.java:555) ~[paper-api-1.18.2-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.craftbukkit.v1_18_R2.CraftServer.disablePlugins(CraftServer.java:494) ~[paper-1.18.2.jar:git-Paper-386]
	at net.minecraft.server.MinecraftServer.stopServer(MinecraftServer.java:972) ~[paper-1.18.2.jar:git-Paper-386]
	at net.minecraft.server.dedicated.DedicatedServer.stopServer(DedicatedServer.java:803) ~[paper-1.18.2.jar:git-Paper-386]
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1271) ~[paper-1.18.2.jar:git-Paper-386]
	at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:316) ~[paper-1.18.2.jar:git-Paper-386]
	at java.lang.Thread.run(Thread.java:833) ~[?:?]
Caused by: java.lang.ClassNotFoundException: com.grinderwolf.swm.nms.CraftSlimeWorld
	at org.bukkit.plugin.java.PluginClassLoader.loadClass0(PluginClassLoader.java:151) ~[paper-api-1.18.2-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.plugin.java.PluginClassLoader.loadClass(PluginClassLoader.java:103) ~[paper-api-1.18.2-R0.1-SNAPSHOT.jar:?]
	at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?]
	... 15 more

[22:59:47] [Server thread/ERROR]: Failed to save chunk [0, 0]
java.util.concurrent.CompletionException: java.lang.IllegalStateException: zip file closed
	at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:315) ~[?:?]
	at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:320) ~[?:?]
	at java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:722) ~[?:?]
	at java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:482) ~[?:?]
	at net.minecraft.server.level.ChunkMap.processUnloads(ChunkMap.java:1026) ~[paper-1.18.2.jar:git-Paper-386]
	at net.minecraft.server.level.ChunkMap.tick(ChunkMap.java:994) ~[paper-1.18.2.jar:git-Paper-386]
	at net.minecraft.server.level.ServerChunkCache.tick(ServerChunkCache.java:913) ~[?:?]
	at net.minecraft.server.MinecraftServer.stopServer(MinecraftServer.java:1016) ~[paper-1.18.2.jar:git-Paper-386]
	at net.minecraft.server.dedicated.DedicatedServer.stopServer(DedicatedServer.java:803) ~[paper-1.18.2.jar:git-Paper-386]
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1271) ~[paper-1.18.2.jar:git-Paper-386]
	at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:316) ~[paper-1.18.2.jar:git-Paper-386]
	at java.lang.Thread.run(Thread.java:833) ~[?:?]
Caused by: java.lang.IllegalStateException: zip file closed
	at java.util.zip.ZipFile.ensureOpen(ZipFile.java:831) ~[?:?]
	at java.util.zip.ZipFile.getEntry(ZipFile.java:330) ~[?:?]
	at java.util.jar.JarFile.getEntry(JarFile.java:518) ~[?:?]
	at java.util.jar.JarFile.getJarEntry(JarFile.java:473) ~[?:?]
	at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:163) ~[paper-api-1.18.2-R0.1-SNAPSHOT.jar:?]
	at java.lang.ClassLoader.loadClass(ClassLoader.java:587) ~[?:?]
	at org.bukkit.plugin.java.PluginClassLoader.loadClass0(PluginClassLoader.java:108) ~[paper-api-1.18.2-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.plugin.java.PluginClassLoader.loadClass(PluginClassLoader.java:103) ~[paper-api-1.18.2-R0.1-SNAPSHOT.jar:?]
	at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?]
	at com.grinderwolf.swm.nms.v1182.CustomWorldServer.convertChunk(CustomWorldServer.java:186) ~[slimeworldmanager-plugin-2.8.0-SNAPSHOT.jar:?]
	at com.grinderwolf.swm.nms.v1182.CustomWorldServer.a(CustomWorldServer.java:378) ~[slimeworldmanager-plugin-2.8.0-SNAPSHOT.jar:?]
	at net.minecraft.server.level.ChunkMap.lambda$scheduleUnload$25(ChunkMap.java:1073) ~[paper-1.18.2.jar:git-Paper-386]
	at java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:718) ~[?:?]
	... 9 more

1.17.1 & 1.18 compatibility / island creation issue

Hey!
I was looking for a fork of the original addon and Ome_R sent me a link to yours. Thanks for making a public fork of the plugin!

I installed it, but for an unknown reason, when I try to create an island, the creation task is endless.
There's no errors, but I can't go to the island, I don't know why.

My server is running Purpur 1.17.1 #1428 under Java 17.0.1 & SSB2 1.8.3 b382 (With MySQL enabled & working)
I am using the latest version of the ASWM-classmodifier & ASWM-Plugin (2.7.0 build 502), as same as the latest version of your plugin, and both ASWM & your plugin are configured to save data in files (I also tried mysql, it didn't help).

I did follow the setup instructions given on https://github.com/Paul19988/Advanced-Slime-World-Manager/blob/develop/.docs/usage/install.md

I also created a world named SuperiorWorld (as this was necessary with ASWM fork of this plugin), it still didn't solve the issue.
I also noticed the island file is created when I create an island, however, it isn't stored in the world.yml file, and same when using mysql to save the data.

Could you please do anything about that?

Issue when joining island

I get this error in console when going to my island: https://pastebin.com/7fwxhgdk When first creating it, there seems to no problems. But if I restart the server and go to it, this occurs and it tells me "An internal error occurred while attempting to perform this command"

My full log: https://pastebin.com/fPJgAh0i

World generation problem

If hell and destination generation is disabled in the configuration file, the SWM world will still be generated

Is it possible to create the world when it is useful?

It will load all worlds into memory when the server is loaded, and save all loaded worlds when saving regularly. In this way, it will occupy a lot of system resources and cause the server to crash

I think we can try to load the world when the empty Island members are online and unload the world when they are offline. In this way, the server performance will be greatly optimized