GithubHelp home page GithubHelp logo

pyczds's Issues

incorrect padding

Hi,

You should fix padding also in _get_token_jwt_payload in authentication.py

  File "/usr/local/lib/python3.10/dist-packages/pyczds/client.py", line 26, in _do_request
    if not self._is_authenticated():
  File "/usr/local/lib/python3.10/dist-packages/pyczds/authentication.py", line 44, in _is_authenticated
    j = self._get_token_jwt_payload()
  File "/usr/local/lib/python3.10/dist-packages/pyczds/authentication.py", line 33, in _get_token_jwt_payload
    s = base64.b64decode(payload_b64)
  File "/usr/lib/python3.10/base64.py", line 87, in b64decode
    return binascii.a2b_base64(s)
binascii.Error: Incorrect padding

after I change it to

s = base64.b64decode(payload_b64 + '=' * (-len(payload_b64) % 4))

it works flawlessly

base64 decode of the JWT failing

Thanks for this library.

When trying to auth against the CZDS service I run into a Python exception: binascii.Error: Incorrect padding (even if www.base64decode.org did decode my JWT base64 string just fine into JSON).

I'm not a pro in Python or this way of authentication at all, but at least padding the base64 string with == made the code work for me.

I patched https://github.com/mdiez/pyCZDS/blob/main/src/pyczds/authentication.py#L33

+        s = base64.b64decode(payload_b64)
-        s = base64.b64decode(f"{payload_b64}==")

I can make a pull request if you prefer, but I'm not sure my hack is the right solution - let me know.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.