mdouchement / hdr Goto Github PK

Replace gometalinter by golangci-lint

Replace util package with more dedicated packages.
Move also generic functions defined in filterand tmo to these new packages (e.g. filter/filter.go#clamp(...)).

Hello and thanks for your work,

I wanted to encode several HDR images into one buffer or file but then rgbe.Decode seems to read more bytes than it should and I can't figure why after reviewing your code.

Encoding and decoding once works fine though.

This, for instance, will throw an error:

rgbe.Encode(buf, img)
rgbe.Encode(buf, img)
img, e := rgbe.Decode(buf)
img, e = rgbe.Decode(buf)

More verbose:

// Encode twice the HDR image and check how many bytes were written
rgbe.Encode(buf, img)
rgbe.Encode(buf, img)
writtenBytes := buf.Len()

// No problem, the first img is fine
img, e := rgbe.Decode(buf)

// More bytes read than written though
fmt.Printf("Bytes read: %v; Bytes written: %v", writtenBytes - buf.Len(), writtenBytes)

// And this returns an invalid format error because we begin to read too far in the buffer
img, e = rgbe.Decode(buf)
if e != nil {
    log.Fatal(e)
}

Any idea why?

https://github.com/golang/go/wiki/Modules

This issue will introduce an important code modification (imports)
https://github.com/golang-standards/project-layout

PS: Looks like these standards are best practices for applications' repositories not libraries' repositories

In the normalize step, the percentile slice could be replaced by a smart function .
The percentile slice uses a large amount of memory for only 2 values are needed (minRGB && maxRGB).

In the paper the white adaptation is provided by a low-pass Gaussian blur.
For performance the StackBlur is used but it have some effects side in the image rendering.

Hi, mdouchement !

Couldn't find a better way to contact you via github, apologies for raising this as an issue.

Many thanks for the hdr library ! It's been very useful for a hobby project of mine, exposure stacking eclipse photos.

Before I found your library, I implemented the fattal02 TMO in Golang. It depends on the fftw3 C library. (To be more honest, I just ported the C implementation from the pfstmo project :) Code here: https://github.com/abworrall/eclipse-hdr/blob/master/pkg/fattal02/fattal02.go

After finding your hdr library, I revised it to implement your API, and also inherit the TMOs you'd already implemented - so thanks again :)

• Adam