GithubHelp home page GithubHelp logo

Comments (4)

johno avatar johno commented on August 26, 2024

Rather than having .jsx specific syntax (assuming inline JSX support), we should have different component contexts for different syntaxes. So when you pass in your component scope you can specify components like so:

import Markdown from '@c8r/markdown'
import {
  Text,
  Heading,
  CodeBlockJSX,
  CodeBlockHTML
} from './ui'

// ...

<Markdown
  text={md}
  components={{
    p: Text.p,
    h1: Heading.h1,
    codeBlock: {
      jsx: CodeBlockJSX,
      html: CodeBlockHTML
  }}
/>

from mdx.

johno avatar johno commented on August 26, 2024

I wonder about the inlining js portion, perhaps that can be left out? Or perhaps it should be JSX {} syntax?

from mdx.

johno avatar johno commented on August 26, 2024

If a markdown document is imported with a custom babel loader, we need to consider the best way to provide a component mapping to the core library. For example, a trivial component mapping might be:

{
  a: Link,
  p: Text,
  h1: Heading,
  // ...
}

One option could be using a context provider:

import React from 'react'
import { MdProvider } from '@compositor/markdown'

import Document from './document.mdx'
import * as ui from './ui'

export default () =>
  <MdProvider components={ui}>
    <Document />
  </MdProvider>

from mdx.

johno avatar johno commented on August 26, 2024

Preliminary import, component mapping, and inlined jsx support completed ✅

from mdx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.