meaningful-ooo / devcontainer-features Goto Github PK

View Code? Open in Web Editor NEW

12.0 2.0 11.0 120 KB

🧰 Development container features

License: MIT License

Shell 99.12% Ruby 0.88%

open-source fish homebrew devcontainer-feature fisher containers devcontainers

devcontainer-features's People

Contributors

Stargazers

Watchers

Forkers

eitsupi guiyomh edouard-lopez oreoshake spykeylife47 danielbraun89 danielmajoinen markiannucci mrluje nikobockerman phachey-aurorasolar

devcontainer-features's Issues

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Repository problems

These problems occurred while renovating this repository. View logs.

WARN: Found renovate config warnings

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

⬆️ Update gitmoji-cli to ^9.4.0

Detected dependencies

github-actions

.github/workflows/fast-forward-pr.yaml

actions/checkout v4

endre-spotlab/fast-forward-js-action 2.1

.github/workflows/release.yaml

actions/checkout v4

devcontainers/action v1

.github/workflows/test.yaml

dorny/paths-filter v3

actions/checkout v4

actions/checkout v4

actions/checkout v4

actions/checkout v4

npm

package.json

gitmoji-cli ^9.1.0

Check this box to trigger a request for Renovate to run again on this repository

Shallow clone flag not working

I'm not sure why and pretty sure it was working last time I used it but the following configuration is doing a full clone :

	"features": {
		"ghcr.io/meaningful-ooo/devcontainer-features/homebrew:2": {
			"shallowClone": true,
			"version": "2.0.3"
		}
    }

Got around it by setting the env var at the end of the Dockerfile 🤷‍♂️

ENV SHALLOW_CLONE="true"

Note: I'm prebuilding the image with npx @devcontainers/cli build but I don't think it change the issue

home-brew permission issues

I notice anything installed by brew in post-create with a vscode devcontianer using the user vscode effects a permission denied.

Fish feature install completes successfully even if fish install fails

I built a dev container using the fish feature from this repository. However, once the container started up fish wasn't actually installed.

After some searching I finally found the logs from Docker Desktop about what had happened during the fish feature installation and the output is attached below.

It's evident that the feature reported successful installation even thought apt failed to install fish due to some likely transient error. In my opinion, the feature install should have failed and I could then have retried.
Now this unsuccessful feature install is cached by Docker as a layer and rebuilding ends up reusing that layer.

Would it perhaps be enough to use set -e in the install.sh script to avoid this?

Log output:

===========================================================================
Feature : fish
Description : Installs fish shell and Fisher plugin manager (optionally)
Id : ghcr.io/meaningful-ooo/devcontainer-features/fish
Version : 1.2.1
Documentation : https://github.com/meaningful-ooo/devcontainer-features/tree/main/src/fish
Options :
FISHER="false"
===========================================================================
Installing fish shell...
deb http://download.opensuse.org/repositories/shells:/fish:/release:/3/Debian_12/ /
Get:1 http://deb.debian.org/debian bookworm InRelease [151 kB]
Get:3 http://deb.debian.org/debian bookworm-updates InRelease [52.1 kB]
Get:4 http://deb.debian.org/debian-security bookworm-security InRelease [48.0 kB]
Get:5 http://download.opensuse.org/repositories/shells:/fish:/release:/3/Debian_12 InRelease [1556 B]
Get:2 https://apt.llvm.org/bookworm llvm-toolchain-bookworm-18 InRelease [6836 B]
Get:6 http://deb.debian.org/debian bookworm/main amd64 Packages [8787 kB]
Get:7 http://download.opensuse.org/repositories/shells:/fish:/release:/3/Debian_12 Packages [1843 B]
Get:8 https://apt.llvm.org/bookworm llvm-toolchain-bookworm-18/main amd64 Packages [20.6 kB]
Get:9 http://deb.debian.org/debian bookworm-updates/main amd64 Packages [12.7 kB]
Get:10 http://deb.debian.org/debian-security bookworm-security/main amd64 Packages [137 kB]
Fetched 9219 kB in 4s (2102 kB/s)
Reading package lists...
Reading package lists...
Building dependency tree...
Reading state information...
The following package was automatically installed and is no longer required:
liblldb-14
Use 'apt autoremove' to remove it.
Suggested packages:
xdg-utils
Recommended packages:
xsel
The following NEW packages will be installed:
fish
0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
Need to get 2558 kB of archives.
After this operation, 18.4 MB of additional disk space will be used.
Ign:1 http://download.opensuse.org/repositories/shells:/fish:/release:/3/Debian_12 fish 3.7.0-1
Ign:1 http://download.opensuse.org/repositories/shells:/fish:/release:/3/Debian_12 fish 3.7.0-1
Ign:1 http://download.opensuse.org/repositories/shells:/fish:/release:/3/Debian_12 fish 3.7.0-1
Err:1 http://download.opensuse.org/repositories/shells:/fish:/release:/3/Debian_12 fish 3.7.0-1
500 Internal Server Error [IP: 195.135.223.226 80]
E: Failed to fetch http://download.opensuse.org/repositories/shells:/fish:/release:/3/Debian_12/amd64/fish_3.7.0-1_amd64.deb 500 Internal Server Error [IP: 195.135.223.226 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
./install.sh: line 109: fish: command not found
Done!

How can I specify multiple homebrew installs?

Thanks for creating a useful feature. I want to install a couple of homebrew packages and can't find an idiomatic way of achieving it.

The best I can do is by repeating the declaration, but this feels a bit hacky and I get a warning of duplicate object key in my IDE.

{
  "features": {
    "ghcr.io/devcontainers-contrib/features/homebrew-package:1": {
      "package": "detect-secrets"
    },
    "ghcr.io/devcontainers-contrib/features/homebrew-package:1": {
      "package": "markdownlint-cli"
    }
  }
}

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.

Jobs

Jooble