medooze / swis Goto Github PK

View Code? Open in Web Editor NEW

2.0 2.0 0.0 487 KB

See-What-I-See

JavaScript 94.90% HTML 5.10%

swis's People

Contributors

Stargazers

Watchers

swis's Issues

Issues with image size

Elisa's screen resolution: 1280x1024
Dave's screen resolution: 1440x900

Implement bidirecctional form/input handling

What is Swis?

Sergio, is this what you are developing for co-browsing or is it something else?

display:fixed elements are not fixed in the reflector

Just that, elements with display:fixed are not fixed when mirrored.

Reflector script execution prevention

While the observer now removes all the scripts from the original page, this doesn't prevent a malware user to inject scripts on the reflector. We need to find a way to avoid that.

Most probable solution is to disable unknown locations in the CSP

cc/ @ibc

Wrong dependencies

This makes no sense:

  "dependencies": {
    "bluebird": "~2.9.34",
    "body-parser": "~1.13.3",
    "cookie-parser": "~1.3.5",
    "cors": "~2.7.1",
    "debug": "~2.2.0",
    "express": "~4.13.3",
    "jade": "~1.11.0",
    "moment": "~2.10.6",
    "morgan": "~1.6.1",
    "pg": "~4.4.1",
    "ramda": "~0.17.1",
    "serve-favicon": "~2.3.0",
    "squel": "~4.1.0",
    "super-error": "~1.1.2"
  },

express as dependency of a browser library?

Don't attempt to send stuff after stop()

Both Reflector and Observer seem to send some data once stop() has been called on them. This basically fails because, at that point, the channel is closed.

TypeError: Cannot read property 'removeEventListener' of undefined

Reflector.prototype.stop = function()
{
    //Clear timer (jic)
    clearTimeout (self.timer);
    //Free recording
    this.recorder  && this.recorder.close();
    //Stop painting
    this.paint(false);
    //Stop canvas
    this.canvas.close();
    //Stop higlhlighter
    this.highlighter.close();
    //Clean reverses
    this.reverse = {};
    this.map = new WeakMap();
    //Media rules
    this.mediarules = {};
    //Remove listener
    this.mirror.removeEventListener("mousemove",this.onmousemove,true);
    this.mirror.removeEventListener("selectionchange",this.onselectionchange,true);
    this.mirror.removeEventListener("submit",this.onsubmit,true);
    this.mirror.defaultView.removeEventListener("rsize",this.onresize,true);

};

The last line fails because this.mirror.defaultView is undefined.

Problem with scroll

When agent scrolls the webpage, user doesn't receive the scroll on his page (the other way works ok: when user scrolls the agent webpage is scrolled too)

Send dimensions (width/height) as double

XSS via onclick attributes

Mirrored elements can have onclick, etc attributes that can execute JavaScript. Since the mirror runs in an iframe this may be "inoffensive", but I'm not 100% sure about that.

<body onmouseover="alert('MOUSE OVER')">lalalal</body>

For example that "works".

The div the observer creates for placing the "paint" does not fit the height of the page, but just the height of the window.

ibc @ibc-macbook in ~/eFace2Face/src/clientCore/node_modules/swis git:master* $ ack onselectionchange
lib/observer.js
714:    document.addEventListener("selectionchange", (this.onselectionchange = function(e) {
989:    document.removeEventListener("selectionchange", this.onselectionchange, true);

lib/reflector.js
428:        mirror.addEventListener("selectionchange", (this.onselectionchange = function(e) {
954:    this.mirror.removeEventListener("selectionchange",this.onselectionchange,true);

www/swis.js
4526:   document.addEventListener("selectionchange", (this.onselectionchange = function(e) {
4801:   document.removeEventListener("selectionchange", this.onselectionchange, true);
5241:       mirror.addEventListener("selectionchange", (this.onselectionchange = function(e) {
5767:   this.mirror.removeEventListener("selectionchange",this.onselectionchange,true);

medooze / swis Goto Github PK

swis's People

Contributors

Stargazers

Watchers

swis's Issues

Recommend Projects

Recommend Topics

Recommend Org

Jobs