Issue with urllib3 using requests 2.31.0 about whoisit

[meeb]

Sure, done. Note though that the whoisit PyPI package just has a requirement of requests without a pinned version. Bumping the required version in the Pipfile (to resolve this issue) doesn't change the package in any way and most people who install the package from PyPI are unaffected by this. Thanks for the issue!

[weslambert]

Thanks for resolving the issue so quickly!

[weslambert]

As an update, I think there might be another issue with urllib3 2.x with DEFAULT_CIPHERS being removed. Should the ssl module and ssl.create_default_context() be used to set the value?

For example, something like the following in utils.py. I haven't tested it.

import ssl
ssl_context = ssl.create_default_context()
< Optionally set ciphers >
ssl_context.set_ciphers('...')
<>
request.packages.urllib3.util.ssl_.DEFAULT_CIPHERS = ssl_context.get_ciphers()

Let me know what you think and if I should create a separate issue.

Thanks!
Wes

[meeb]

Ah, yes that will require an additional patch. Looks like it will need to be moved to a requests adapter. Feel free to create an new issue.

[weslambert]

Will do. Thanks!